Remove fixed TODOs

SpongePowered · Oct 14, 2023 · 32cb65c · 32cb65c
1 parent e7a3961
commit 32cb65c
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/...xins/java/org/spongepowered/vanilla/mixin/core/advancements/Advancement_BuilderMixin.java b/...xins/java/org/spongepowered/vanilla/mixin/core/advancements/Advancement_BuilderMixin.java
@@ -36,7 +36,7 @@ public abstract class Advancement_BuilderMixin implements AdvancementBridge {
 
     // Serializing causes the following JSON: "rewards": null
     // Deserializing does consider JsonNull to be an error here - so we fix it
-    @Redirect(method = "fromJson", at = @At(value = "INVOKE", target = "Lcom/google/gson/JsonObject;has(Ljava/lang/String;)Z", ordinal = 2, remap = false)) // TODO SF 1.19.4
+    @Redirect(method = "fromJson", at = @At(value = "INVOKE", target = "Lcom/google/gson/JsonObject;has(Ljava/lang/String;)Z", ordinal = 2, remap = false))
     private static boolean impl$onHasRewards(final JsonObject p_241043_0_, final String rewards) {
         if (p_241043_0_.has(rewards)) {
             return !p_241043_0_.get(rewards).isJsonNull();

diff --git a/.../src/mixins/java/org/spongepowered/vanilla/mixin/core/commands/CommandsMixin_Vanilla.java b/.../src/mixins/java/org/spongepowered/vanilla/mixin/core/commands/CommandsMixin_Vanilla.java
@@ -62,7 +62,7 @@ public abstract class CommandsMixin_Vanilla {
     private WeakHashMap<ServerPlayer, Map<CommandNode<CommandSourceStack>, List<CommandNode<SharedSuggestionProvider>>>> impl$playerNodeCache;
     private SpongeCommandManager impl$commandManager;
 
-    @Redirect(method = "sendCommands", at = @At(value = "INVOKE", target = "Lnet/minecraft/commands/Commands;fillUsableCommands(Lcom/mojang/brigadier/tree/CommandNode;Lcom/mojang/brigadier/tree/CommandNode;Lnet/minecraft/commands/CommandSourceStack;Ljava/util/Map;)V")) // TODO SF 1.19.4
+    @Redirect(method = "sendCommands", at = @At(value = "INVOKE", target = "Lnet/minecraft/commands/Commands;fillUsableCommands(Lcom/mojang/brigadier/tree/CommandNode;Lcom/mojang/brigadier/tree/CommandNode;Lnet/minecraft/commands/CommandSourceStack;Ljava/util/Map;)V"))
     private void impl$addNonBrigSuggestions(
         final Commands commands,
         final CommandNode<CommandSourceStack> p_197052_1_,

diff --git a/...g/spongepowered/vanilla/mixin/core/server/commands/SpreadPlayersCommandMixin_Vanilla.java b/...g/spongepowered/vanilla/mixin/core/server/commands/SpreadPlayersCommandMixin_Vanilla.java
@@ -41,7 +41,7 @@
 @Mixin(SpreadPlayersCommand.class)
 public abstract class SpreadPlayersCommandMixin_Vanilla {
 
-     @Redirect(method = "setPlayerPositions", at = @At(value = "INVOKE", target = "Lnet/minecraft/world/entity/Entity;teleportTo(Lnet/minecraft/server/level/ServerLevel;DDDLjava/util/Set;FF)Z")) // TODO SF 1.19.4
+    @Redirect(method = "setPlayerPositions", at = @At(value = "INVOKE", target = "Lnet/minecraft/world/entity/Entity;teleportTo(Lnet/minecraft/server/level/ServerLevel;DDDLjava/util/Set;FF)Z"))
     private static boolean vanilla$createCauseFrameForTeleport(
         final Entity instance, final ServerLevel level, final double x, final double y,
         final double z, final Set<RelativeMovement> relativeMovements, final float yRot, final float xRot) {