Make objects const

SpinlockLabs · Nov 8, 2023 · 0c95f3b · 0c95f3b
1 parent e1cfd59
commit 0c95f3b
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 16 deletions.
diff --git a/lib/src/common/model/changes.dart b/lib/src/common/model/changes.dart
@@ -1,59 +1,66 @@
 import 'package:json_annotation/json_annotation.dart';
+import 'package:meta/meta.dart';
 
 part 'changes.g.dart';
 
+@immutable
 @JsonSerializable()
 class Ref {
-  Ref(this.from);
-  String? from;
+  const Ref(this.from);
+  final String? from;
 
   factory Ref.fromJson(Map<String, dynamic> input) => _$RefFromJson(input);
   Map<String, dynamic> toJson() => _$RefToJson(this);
 }
 
+@immutable
 @JsonSerializable()
 class Sha {
-  Sha(this.from);
-  String? from;
+  const Sha(this.from);
+  final String? from;
 
   factory Sha.fromJson(Map<String, dynamic> input) => _$ShaFromJson(input);
   Map<String, dynamic> toJson() => _$ShaToJson(this);
 }
 
+@immutable
 @JsonSerializable()
 class Base {
-  Base(this.ref, this.sha);
-  Ref? ref;
-  Sha? sha;
+  const Base(this.ref, this.sha);
+  final Ref? ref;
+  final Sha? sha;
 
   factory Base.fromJson(Map<String, dynamic> input) => _$BaseFromJson(input);
   Map<String, dynamic> toJson() => _$BaseToJson(this);
 }
 
+@immutable
 @JsonSerializable()
 class Body {
-  Body(this.from);
-  String? from;
+  const Body(this.from);
+  final String? from;
 
   factory Body.fromJson(Map<String, dynamic> input) => _$BodyFromJson(input);
   Map<String, dynamic> toJson() => _$BodyToJson(this);
 }
 
+@immutable
 @JsonSerializable()
 class Title {
-  Title({this.from});
-  String? from;
+  const Title({this.from});
+  final String? from;
 
   factory Title.fromJson(Map<String, dynamic> input) => _$TitleFromJson(input);
   Map<String, dynamic> toJson() => _$TitleToJson(this);
 }
 
+@immutable
 @JsonSerializable()
 class Changes {
-  Changes(this.base, this.body, this.title);
-  Base? base;
-  Body? body;
-  Title? title;
+  const Changes(this.base, this.body, this.title);
+  final Base? base;
+  final Body? body;
+  final Title? title;
 
   factory Changes.fromJson(Map<String, dynamic> input) =>
       _$ChangesFromJson(input);

diff --git a/lib/src/server/hooks.dart b/lib/src/server/hooks.dart
@@ -1,9 +1,11 @@
 import 'dart:async';
 import 'dart:convert';
 import 'dart:io';
-import 'package:github/src/common/model/changes.dart';
+
 import 'package:json_annotation/json_annotation.dart';
+
 import '../common.dart';
+import '../common/model/changes.dart';
 
 part 'hooks.g.dart';