Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MySQL and SQLite #1378

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Add support for MySQL and SQLite #1378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
11e02de
Add support for MySQL and SQLite
Bramjetten Jul 31, 2024
a63c25b
Change references to jsonb to json
Bramjetten Oct 8, 2024
474d3ee
Make the replace signed id job database-agnostic
Bramjetten Oct 8, 2024
2529be5
Update to ruby 3.3.5
Bramjetten Oct 8, 2024
2cd81df
Add database adapter gems to test group
Bramjetten Oct 8, 2024
00c6f23
Add SQLite database tests
Bramjetten Oct 8, 2024
3504aad
Update Gemfile.lock
Bramjetten Oct 8, 2024
c74906d
Remove other test for now
Bramjetten Oct 8, 2024
1afd0c8
Use v4
Bramjetten Oct 8, 2024
55b1798
lets revert back to ruby 3.2 for now
Bramjetten Oct 8, 2024
218c08e
Fixtures
Bramjetten Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/ruby.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
--health-retries 5

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4

- name: Install libvips
run: sudo apt-get install -y libvips
Expand All @@ -50,7 +50,7 @@ jobs:
env:
RAILS_ENV: test
run: |
cp test/dummy/config/database.yml.ci test/dummy/config/database.yml
cp test/dummy/config/database.yml.postgresql test/dummy/config/database.yml
bin/rails db:setup

- name: Compile assets
Expand All @@ -66,3 +66,4 @@ jobs:
GIT_BRANCH: ${GITHUB_REF/refs\/heads\//}
run: ./cc-test-reporter after-build -r ${{ secrets.CodeClimate }}
if: github.ref == 'refs/heads/main'

5 changes: 5 additions & 0 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,11 @@ group :test do
gem "simplecov"
gem "codeclimate-test-reporter", "~> 1.0.0"

# Databases
gem "pg"
gem "mysql2"
gem "sqlite3"

# System tests
gem "capybara"
gem "selenium-webdriver", "~> 4.11.0"
Expand Down
Loading
Loading