Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests and CI/CD #40

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Conversation

chyumin
Copy link
Collaborator

@chyumin chyumin commented Jun 20, 2022

Starterd from PR #26

Before merging, above git secrets needs to be set:

  • DOCKER_USER
  • DOCKER_PASSWORD

Summary:

  • Build, Test and Push images for changed Dockerfiles
  • Depends on spikeinterface's PR

TODO:

  • Update requirements_test.txt after merge on SI's project

@bendichter
Copy link
Collaborator

@chyumin the automatic pushing to dockerhub looks good, but could you please do that in a separate PR? What I really want to prioritize is a working test CI.

@chyumin
Copy link
Collaborator Author

chyumin commented Jun 20, 2022

@bendichter Alright. I'll create another PR with only Tests-CI

@chyumin chyumin mentioned this pull request Jun 20, 2022
@chyumin chyumin marked this pull request as ready for review June 27, 2022 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants