Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to SDK Format and add NET5 as target. Also add Test app for NET5. #14

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

muntablues
Copy link

No description provided.

@amellini
Copy link

Please merge this PR

@kmcginnes kmcginnes changed the base branch from master to develop April 11, 2021 01:19
@kmcginnes kmcginnes self-requested a review April 11, 2021 01:20
@kmcginnes kmcginnes self-assigned this Apr 11, 2021
@kmcginnes kmcginnes added this to the v2.0 milestone Apr 11, 2021
@kmcginnes
Copy link
Collaborator

This PR looks great. Sorry for such a slow response.

I spent last night trying to get the project to build in the old CI system I had set up (AppVeyor), but didn't have much luck. So I started transitioning to GitHub Actions. I have it building and uploading the nuget package to GitHub as an artifact, but I haven't set up the tests yet.

I'll be honest, this will likely progress slowly. I will also need some assistance. I no longer use Windows and I only have an Apple Silicon M1 Mac. I don't plan to get Windows up and running just to test if this package still works as advertised in WPF.

So, if I can get a volunteer to be the tester for getting this across the finish line that would be a huge help.

@kmcginnes kmcginnes changed the title Switch to SDK Format and add NET5 as target. Also add Test app fro NET5. Switch to SDK Format and add NET5 as target. Also add Test app for NET5. Apr 12, 2021
@amellini
Copy link

@kmcginnes I'll be happy to test this, what kind of test do you need?
Usage test or you need to test code and use it in a custom app?

@guenterrudigier
Copy link

@kmcginnes
Can you please merge die PR, THX

@kmcginnes
Copy link
Collaborator

I'm sorry, it is not as simple as that.

Months ago I attempted to get things set up in order to merge this, but continually ran in to problems. And then from there I just haven't found a dedicated set of many hours to devote to this work.

Here's what I remember that needs to happen:

  • Move entire CI to something new (I was setting up GitHub Actions)
    • Ensure deployments to the public NuGet repository do not occur until I manually approve a release
    • Ensure all tests run and pass
    • Ensure artifacts are posted to the "Releases" area of GitHub
    • Ensure build buttons on GitHub readme page are working
  • Update code base for the breaking change moving to .net 5
    • Update the major version to indicate a breaking change
    • Ensure the Nuget package works properly in a brand new .net 5 application
    • Remove any old code that is no longer necessary
    • Update csproj files to the new way
  • Push a beta version of the Nuget package to the public NuGet repository
    • Write release notes
    • Update GitHub readme

There is probably more, but once I realized that this was going to be a multiple hour thing I had to give up on it for the time being, and I never made it back around to completing these items.

I welcome some assistance on this front. There is a branch called github-actions that was my initial work on this front. Perhaps you can help me complete it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants