Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First cut at support for a 'make install' #105

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dkfellows
Copy link
Member

The core of the fix for SpiNNakerManchester/SupportScripts#21

@dkfellows dkfellows added this to the 5.1.0 milestone Sep 9, 2019
@rowleya
Copy link
Member

rowleya commented Oct 22, 2019

Running make install currently fails in Ubuntu (on Windows) with:

Makefile:28: recipe for target 'install' failed
make: *** [install] Error 1

It isn't clear what went wrong, but Ubuntu doesn't like it...

Note that I didn't change my $SPINN_DIRS, so it currently points at the same place as the files come from, but this was the case I was trying to test (since this is how most users will have their systems configured currently; I wanted to see what would happen).

@rowleya
Copy link
Member

rowleya commented Oct 22, 2019

Quick additional check; if I set $SPINN_DIRS before make, make fails:

make[1]: Entering directory '/mnt/c/Users/zzalsar4/git/spinnaker_tools/sark'
make[1]: *** No rule to make target '/home/zzalsar4/test_dir//include/spinnaker.h', needed by '../build/gnu/spinnaker.gas'.  Stop.
make[1]: Leaving directory '/mnt/c/Users/zzalsar4/git/spinnaker_tools/sark'
Makefile:22: recipe for target 'all' failed
make: *** [all] Error 2

If I do the same having already called make, I get the same error as above.

@dkfellows dkfellows modified the milestones: 5.1.0, 6.0.0 Nov 22, 2019
@Christian-B
Copy link
Member

Is this PR worth keeping?

@dkfellows dkfellows modified the milestones: 6.0.0, 7.0.0 Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants