Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing for PACMAN #1510

Merged
merged 2 commits into from
Dec 23, 2024
Merged

Typing for PACMAN #1510

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4617fba
None return
Christian-B Dec 2, 2024
2110a44
merged in master
Christian-B Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions spynnaker/pyNN/external_devices_models/spif_output_device.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,8 @@ def __is_power_of_2(self, v):
return (v & (v - 1) == 0) and (v != 0)

@overrides(ApplicationFPGAVertex.add_incoming_edge)
def add_incoming_edge(
self, edge: ApplicationEdge, partition: ApplicationEdgePartition):
def add_incoming_edge(self, edge: ApplicationEdge,
partition: ApplicationEdgePartition) -> None:
# Only add edges from PopulationApplicationVertices
if not isinstance(edge.pre_vertex, PopulationApplicationVertex):
if not isinstance(edge.pre_vertex, CommandSender):
Expand Down
2 changes: 1 addition & 1 deletion spynnaker/pyNN/models/neuron/abstract_population_vertex.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,7 +467,7 @@ def get_max_atoms_per_dimension_per_core(self) -> Tuple[int, ...]:
@overrides(PopulationApplicationVertex.
set_max_atoms_per_dimension_per_core)
def set_max_atoms_per_dimension_per_core(
self, new_value: Union[None, int, Tuple[int, ...]]):
self, new_value: Union[None, int, Tuple[int, ...]]) -> None:
if new_value is not None:
max_atoms = self.__synapse_dynamics.absolute_max_atoms_per_core
if numpy.prod(new_value) > max_atoms:
Expand Down
Loading