Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code changes from typing branch #249

Closed
wants to merge 11 commits into from
Closed

code changes from typing branch #249

wants to merge 11 commits into from

Conversation

Christian-B
Copy link
Member

@Christian-B Christian-B commented Oct 12, 2023 •
edited
Loading

Config_loader

  • minor type changes from roc

config_handler

  • cleaner handling when pre load is required

data_view

  • Moved setting attributes to init method

executable_finder

  • more checking for None for typed (different style to roc)

log.py

  • better handling of None (different style to roc)
  • Use ClassName for class attributes

AbstractDict

  • dont allow reset if no default.

AbstractList

  • minor code changes to support typing

@coveralls
Copy link

coveralls commented Oct 12, 2023 •
edited
Loading

Coverage Status

coverage: 89.815% (-0.05%) from 89.867% when pulling 6f0091e on roc_cherry into 60b1809 on master.

@Christian-B
Copy link
Member Author

don in main typing branch

@Christian-B Christian-B deleted the roc_cherry branch October 17, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
incomplete_left_for_further_release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Christian-B @coveralls