reduce-op-complexity #233
Merged
reduce-op-complexity #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What a mess...
The types for the overrides decorator are particularly tricky
Turns out that abstractproperty decorators give mypy severe indigestion, but replacing them with property and abstractmethod works fine. Bleah.
The ranged stuff is *complicated!*
Positional-only parameters make their appearance now we have 3.8 as a minimum
dkfellows
changed the title
Christian-B
approved these changes
Aug 29, 2023
simpler way to do configholder
Closed
Christian-B
changed the title
Christian-B
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not doing types for theOK, so I did those. I've got better at writing types.matrixorrangedpackages. Those are complicated!Note that we're a long long way off being able to use mypy as a standard checking utility. If you want to enable it in your IDE, that's fine (it's what I've done).The types are now checked with
mypy. Not all sub-packages are typed or typed fully, but the key ones are.