-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VOR related models and provenance #927
Open
andrewgait
wants to merge
59
commits into
master
Choose a base branch
from
icub_vor_update
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: spinn_front_end_common/interface/interface_functions/placements_provenance_gatherer.py
Conflicts: spinn_front_end_common/interface/interface_functions/placements_provenance_gatherer.py
- may be best to move custom "SpiNNCer" provenance dataframe etc. outside of the current toolchain for now, and read from prov database
Conflicts: spinn_front_end_common/interface/provenance/db.sql spinn_front_end_common/interface/provenance/provenance_writer.py unittests/interface/provenance/test_provenance_database.py
Conflicts: spinn_front_end_common/interface/provenance/db.sql spinn_front_end_common/interface/provenance/provenance_writer.py unittests/interface/provenance/test_provenance_database.py
rowleya
approved these changes
Aug 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine. Note that the lut data is kind-of sPyNNaker specific, but at the same time not so much that it doesn't fit in here...
Update test as well
dkfellows
added
reporting/provenance
and removed
incomplete_left_for_further_release
Not for current release in preparation.
labels
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extra provenance information relating to the VOR PR in SpiNNakerManchester/sPyNNaker#1152