Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Energy fixes #1254

Merged
merged 5 commits into from
Dec 30, 2024
Merged

Energy fixes #1254

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5018f8c
data loading time even if not using monitors
Christian-B Dec 17, 2024
ebf4135
remove hard coded values
Christian-B Dec 17, 2024
8e6cea2
typing fix
Christian-B Dec 17, 2024
bf11ea8
Merge branch 'master' into energy_fixes
Christian-B Dec 18, 2024
0b64734
Merge branch 'master' into energy_fixes
Christian-B Dec 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions spinn_front_end_common/interface/interface_functions/compute_energy_used.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@
from spinn_front_end_common.interface.provenance import (
GlobalProvenance, ProvenanceReader, TimerCategory, TimerWork)
from spinn_front_end_common.utilities.utility_objs import PowerUsed
from spinn_front_end_common.interface.interface_functions\
.load_data_specification import load_using_advanced_monitors
from spinn_front_end_common.utility_models\
.chip_power_monitor_machine_vertex import (
RECORDING_CHANNEL, ChipPowerMonitorMachineVertex)
Expand Down Expand Up @@ -69,10 +67,8 @@ def compute_energy_used(checkpoint: Optional[int] = None) -> PowerUsed:

# Separate out processes that are part of the others but that happen
# on the machine, so we can account for active machine, not idle
data_loading_ms = 0
if load_using_advanced_monitors():
data_loading_ms = db.get_timer_sum_by_work(TimerWork.LOADING_DATA)
loading_ms -= data_loading_ms
data_loading_ms = db.get_timer_sum_by_work(TimerWork.LOADING_DATA)
loading_ms -= data_loading_ms
data_extraction_ms = 0
if get_config_bool("Machine", "enable_advanced_monitor_support"):
data_extraction_ms = db.get_timer_sum_by_work(
Expand Down Expand Up @@ -113,14 +109,19 @@ def compute_energy_used(checkpoint: Optional[int] = None) -> PowerUsed:
n_active_cores += 1
n_active_chips = len(active_cores)

# TODO confirm Power monitors are not included here
extra_monitors_per_chip = (version.n_scamp_cores
+ FecDataView.get_all_monitor_cores() - 1)
extra_monitors_per_board = (version.n_scamp_cores +
FecDataView.get_ethernet_monitor_cores() - 1)
run_chip_active_time = _extract_cores_active_time(
checkpoint, active_cores, version)
load_chip_active_time = _make_extra_monitor_core_use(
data_loading_ms, machine, version.n_scamp_cores + 2,
version.n_scamp_cores + 1)
data_loading_ms, machine, extra_monitors_per_board,
extra_monitors_per_chip)
extraction_chip_active_time = _make_extra_monitor_core_use(
data_extraction_ms, machine, version.n_scamp_cores + 2,
version.n_scamp_cores + 1)
data_extraction_ms, machine, extra_monitors_per_board,
extra_monitors_per_chip)

run_router_packets = _extract_router_packets("Run", version)
load_router_packets = _extract_router_packets("Load", version)
Expand Down
Loading