Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data_specification_loaded to turn off requires data spec / reset #1227

Closed
wants to merge 1 commit into from
Closed

data_specification_loaded to turn off requires data spec / reset #1227

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions spinn_front_end_common/interface/abstract_spinnaker_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,8 @@
from spinn_front_end_common.interface.splitter_selectors import (
splitter_selector)
from spinn_front_end_common.interface.java_caller import JavaCaller
from spinn_front_end_common.utilities.exceptions import ConfigurationException
from spinn_front_end_common.utilities.exceptions import (
ConfigurationException, SpinnFrontEndException)
from spinn_front_end_common.utilities.report_functions import (
bitfield_compressor_report, board_chip_report, EnergyReport,
fixed_route_from_machine_report,
Expand Down Expand Up @@ -576,12 +577,15 @@ def __run(self, run_time: Optional[float], sync_time: float):

# If we have never run before, or the graph has changed,
# start by performing mapping
if (self._data_writer.get_requires_mapping() and
if (self._data_writer.get_requires_data_generation() and
self._data_writer.is_ran_last()):
self.stop()
raise NotImplementedError(
"The network cannot be changed between runs without"
" resetting")
if self._data_writer.get_requires_mapping():
raise NotImplementedError(
"The network cannot be changed between runs without"
" resetting")
else:
raise SpinnFrontEndException("The network needs to be reset")

# If we have reset and the graph has changed, stop any running
# application
Expand Down Expand Up @@ -1742,6 +1746,7 @@ def _execute_load_system_data_specification(self) -> None:
if timer.skip_if_virtual_board():
return
load_system_data_specs()
self._data_writer.data_specification_loaded()

def _execute_load_system_executable_images(self) -> None:
"""
Expand Down Expand Up @@ -1926,6 +1931,7 @@ def _execute_dsg_region_reloader(self) -> None:
if timer.skip_if_virtual_board():
return
reload_dsg_regions()
self._data_writer.data_specification_loaded()

def _execute_graph_provenance_gatherer(self) -> None:
"""
Expand Down