Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No longer use AbstractContextManager #1130

Merged
merged 2 commits into from
Oct 13, 2023
Merged

No longer use AbstractContextManager #1130

merged 2 commits into from
Oct 13, 2023

Conversation

Christian-B
Copy link
Member

@Christian-B Christian-B commented Oct 12, 2023 •
edited
Loading

Must be done before SpiNNakerManchester/SpiNNUtils#250

BaseDatabase inherits the methods from SQLiteDB

SQLiteDB has a different implementation for both enter and exit

NotificationProtocol is not used in context

@Christian-B Christian-B mentioned this pull request Oct 12, 2023
Merged
@Christian-B Christian-B merged commit cc7fe9e into master Oct 13, 2023
@Christian-B Christian-B deleted the AbstractContextManager branch October 13, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rowleya rowleya rowleya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Christian-B @rowleya