Live vs time callback #1114
Merged
Live vs time callback #1114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 28, 2023
Closed
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1116 is a simpler alternative
The LiveEventConnection has two different even callback methods.
They take different parameters and without this PR this works by usage not by implementation
Based on idea from #1062
But not depending on the caller happening to know that an extra parameter has been added.
Must be done at the same time as:
SpiNNakerManchester/sPyNNaker#1388
SpiNNakerManchester/SpiNNGym#83
SpiNNakerManchester/Visualiser#26
SpiNNakerManchester/PyNNExamples#109
SpiNNakerManchester/sPyNNakerVisualisers#40
SpiNNakerManchester/SpiNNakerGraphFrontEnd#260
tested by:
SpiNNakerManchester/IntegrationTests#238