Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when governed_app_vertex is requested it is no loner None #528

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

Christian-B
Copy link
Member

@Christian-B Christian-B commented Oct 24, 2023

This is a small change mainly designed to show that a change in the Typing branches is not needed.

In that pr there are two method to get the app vertex

governed_app_vertex which could return a None
_governed_app_vertex which never returns a None

This pr shows that governed_app_vertex can just not return None

If someone does need to check if the app vertex is not yet set we should add a has_app_vertex method.

tested by:
http://apollo.cs.man.ac.uk:8080/blue/organizations/jenkins/Integration%20Tests/detail/governed_app_vertex_never_none/1/pipeline

@Christian-B Christian-B merged commit c962251 into master Oct 25, 2023
5 checks passed
@Christian-B Christian-B deleted the governed_app_vertex_never_none branch October 25, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant