Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConvectiveHeating implemented #639

Merged
merged 6 commits into from
Dec 14, 2024
Merged

ConvectiveHeating implemented #639

merged 6 commits into from
Dec 14, 2024

Conversation

milankl
Copy link
Member

@milankl milankl commented Dec 14, 2024

closes #567

@milankl milankl added the parameterizations 🌧️ Parameterizations of unresolved physical processes label Dec 14, 2024
@milankl milankl requested a review from KristianJS December 14, 2024 00:03
@milankl
Copy link
Member Author

milankl commented Dec 14, 2024

@KristianJS to be used like

spectral_grid = SpectralGrid()
convection = ConvectiveHeating(spectral_grid, p₀ = 525) # specify non-defaults as keyword args here     
model = PrimitiveDryModel(spectral_grid; convection)    # pass on to model constructor
simulation = initialize!(model)
run!(simulation)

ConvectiveHeating is implemented as a parameterization (not a forcing) given it's formulated in pressure coordinates and especially because it's presumably not to be used in combination with other convection schemes. So passing convection here on will use that instead of the more complicated default Betts-Miller scheme. Not tested yet, would you?

@milankl milankl merged commit 28dbcac into main Dec 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parameterizations 🌧️ Parameterizations of unresolved physical processes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Heating as model component
1 participant