Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forcing/drag for primitive models too #635

Merged
merged 10 commits into from
Dec 14, 2024
Merged

Forcing/drag for primitive models too #635

merged 10 commits into from
Dec 14, 2024

Conversation

milankl
Copy link
Member

@milankl milankl commented Dec 12, 2024

  • Moves JetDrag and StochasticStirring from StochasticStir.jl into the main repo @KristianJS
  • StochasticStirring now depends on model.random_process* @KristianJS
  • calls to forcing! and drag! in the primitive equation models as part of the dynamics, after the parameterization, before the other dynamics (i.e. always accumulate tendencies, otherwise parameterizations are overwritten.

(*) e.g. random_process = SpectralAR1Process(spectral_grid, wavenumber=N, time_scale=T, ...). Default NoRandomProcess so this needs to be explicitly passed to the model constructor when using StochasticStirring. This way we can reuse the random_process infrastructure for SPPT etc too. And in fact, the defaults of SpectralAR1Process are more geared towards that (randn with std 1/3 clamp at (-1, 1)).

@milankl milankl added forcing 🏋️ Forcing of the momentum equations stochastic 🎲 Random or stochastic components in a simulation labels Dec 12, 2024
@milankl milankl merged commit f38f918 into main Dec 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forcing 🏋️ Forcing of the momentum equations stochastic 🎲 Random or stochastic components in a simulation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant