Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lambda support vpc #20

Merged
merged 6 commits into from
Dec 31, 2024
Merged

lambda support vpc #20

merged 6 commits into from
Dec 31, 2024

Conversation

gabbyhagag
Copy link
Member

Support VPC to lambda.
After this change, you can add VPC configuration to lambda and it will add the policy.

{
  vpc_config = {
    subnet_ids         = ["subnet-12345678", "subnet-87654321"]
    security_group_ids = ["sg-12345678"]
  }
}

ChengaDev
ChengaDev reviewed Dec 2, 2024
View reviewed changes
examples/basic-terraform-integration.tf Outdated Show resolved Hide resolved
modules/lambda/lambda.tf Show resolved Hide resolved
eladbash
eladbash reviewed Dec 23, 2024
View reviewed changes
examples/lambda-in-vpc.tf Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vpc in lambda

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed:
9007bf3

eladbash
eladbash reviewed Dec 23, 2024
View reviewed changes
examples/lambda-in-vpc.tf Outdated

env_vars = {
# Required environment variables
SPECTRAL_DSN = "MySpectralDSN"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think better avoid spectral dsn in the examples - the best practice is to use vault since this is a secret

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed:
9007bf3

@ChengaDev ChengaDev merged commit 0e052e9 into SpectralOps:main Dec 31, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chkp-gavrielh chkp-gavrielh chkp-gavrielh left review comments

@ChengaDev ChengaDev ChengaDev approved these changes

@eladbash eladbash eladbash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gabbyhagag @eladbash @ChengaDev @chkp-gavrielh