Code

BED-4965 - Owns/Owner Rework#993

Code

Open

Mayyhem wants to merge 38 commits intomainSpecterOps/BloodHound:mainfrom BED-4965SpecterOps/BloodHound:BED-4965Copy head branch name to clipboard

+3,353-1,229

Commits

Commits on Jan 21, 2025

• wip: initial start on owns edge changes

  

  rvazarkar

  authored and

  zinic

  committed
  5117089

  Copy full SHA for 5117089

• wip: write post operations for writeowner/owns, update ingest

  

  rvazarkar

  authored and

  zinic

  committed
  cbb26fc

  Copy full SHA for cbb26fc

• wip: fix return type

  

  rvazarkar

  authored and

  zinic

  committed
  3ff2a12

  Copy full SHA for 3ff2a12

• wip: remove unnecessary bool

  

  rvazarkar

  authored and

  zinic

  committed
  3ccb166

  Copy full SHA for 3ccb166

• BED-4965: WIP merge changes to Owns/WriteOwner post-processing (#931)

  Show description for fd46820
  

  Mayyhem

  authored and

  zinic

  committed
  fd46820

  Copy full SHA for fd46820

• wip: fix post

  

  rvazarkar

  authored and

  zinic

  committed
  e7ceaf2

  Copy full SHA for e7ceaf2

• Updated Owns/WriteOwner logic to check if any non-abusable ACEs granting OWNER RIGHTS are present

  

  Mayyhem

  authored and

  zinic

  committed
  5b66fcc

  Copy full SHA for 5b66fcc

• Updated inherited vs. non-inherited benign ACE logic for WriteOwner

  

  Mayyhem

  authored and

  zinic

  committed
  1fb1404

  Copy full SHA for 1fb1404

• Added Owns/WriteOwner to post-processed edges, deleted commented code

  

  Mayyhem

  authored and

  zinic

  committed
  56d03b0

  Copy full SHA for 56d03b0

• Return stats for aggregation

  

  Mayyhem

  authored and

  zinic

  committed
  bdd3025

  Copy full SHA for bdd3025

• Return cursor.Error() instead of nil

  

  Mayyhem

  authored and

  zinic

  committed
  137fafb

  Copy full SHA for 137fafb

• Updated Owns/WriteOwner[LimitedRights] help text

  

  Mayyhem

  authored and

  zinic

  committed
  af19cc5

  Copy full SHA for af19cc5

• Fallback to add Owns/WriteOwner if fetching dSHeuristics/Admins fails

  

  Mayyhem

  authored and

  zinic

  committed
  157eada

  Copy full SHA for 157eada

• Update docs URL

  

  Mayyhem

  authored and

  zinic

  committed
  176f223

  Copy full SHA for 176f223

• Initial harnesses for Owns/WriteOwner changes

  

  Mayyhem

  authored and

  zinic

  committed
  d553ffb

  Copy full SHA for d553ffb

• Remove unused variable

  

  Mayyhem

  authored and

  zinic

  committed
  6eeea57

  Copy full SHA for 6eeea57

• Accounted for abusable permissions that are deleted on owner change

  

  Mayyhem

  authored and

  zinic

  committed
  e873f2a

  Copy full SHA for e873f2a

• Update Owns and WriteOwner setup harness

  

  Mayyhem

  authored and

  zinic

  committed
  684e31d

  Copy full SHA for 684e31d

• Confirmed harness data is accurate and is processed as expected by PostOwnsWriteOwner

  

  Mayyhem

  authored and

  zinic

  committed
  1cec2c6

  Copy full SHA for 1cec2c6

• Completed Owns edge tests

  

  Mayyhem

  authored and

  zinic

  committed
  0a75308

  Copy full SHA for 0a75308

• Completed WriteOwner edge tests

  

  Mayyhem

  authored and

  zinic

  committed
  36e5cfc

  Copy full SHA for 36e5cfc

• Accounted for all abusability and inheritance situations for user and computer object ownership and WriteOwner permissions

  

  Mayyhem

  authored and

  zinic

  committed
  71085a2

  Copy full SHA for 71085a2

• Updated command to identify dSHeuristics, minor formatting

  

  Mayyhem

  authored and

  zinic

  committed
  be7721a

  Copy full SHA for be7721a

• Added test harness and integration testing for collector versions prior to change

  

  Mayyhem

  authored and

  zinic

  committed
  bb6fdad

  Copy full SHA for bb6fdad

• Formatting changes from just generate

  

  Mayyhem

  authored and

  zinic

  committed
  803411a

  Copy full SHA for 803411a

• Finished integration tests for post-processing collections from SharpHound versions prior to change

  

  Mayyhem

  authored and

  zinic

  committed
  41b00ad

  Copy full SHA for 41b00ad

• Tested prior SharpHound collection file upload followed by newer version file upload

  

  Mayyhem

  authored and

  zinic

  committed
  80ffb20

  Copy full SHA for 80ffb20

• Fetch dSHeuristics and admin IDs once and do not return on error

  

  Mayyhem

  authored and

  zinic

  committed
  750c0c1

  Copy full SHA for 750c0c1

• Added null check for adminGroupIds

  

  Mayyhem

  authored and

  zinic

  committed
  896d219

  Copy full SHA for 896d219

• Remove unused variables

  

  Mayyhem

  authored and

  zinic

  committed
  74c18b0

  Copy full SHA for 74c18b0

• Return/log errors, fix comments, remove raw edges from ACLRelationships to address PR comments

  

  Mayyhem

  authored and

  zinic

  committed
  0c30b79

  Copy full SHA for 0c30b79

• Prepare for code review

  

  Mayyhem

  authored and

  zinic

  committed
  44cb21e

  Copy full SHA for 44cb21e

• chore: code review

  zinic

  committed
  932a121

  Copy full SHA for 932a121

• Addressed FIXME changes requested during code review

  

  Mayyhem

  authored and

  zinic

  committed
  426002a

  Copy full SHA for 426002a

• Added OwnsRaw and WriteOwnerRaw back to ACLRelationships so they are recalculated

  

  Mayyhem

  authored and

  zinic

  committed
  daad1f8

  Copy full SHA for daad1f8

• Adhere to conditional statement standard, refactor doesAny[Inherited]AceGrantOwnerRights, rename confusing struct

  

  Mayyhem

  authored and

  zinic

  committed
  a4d38bb

  Copy full SHA for a4d38bb

• chore: patchup schema

  zinic

  committed
  0d2d217

  Copy full SHA for 0d2d217

Commits on Jan 23, 2025

• Update to fix static analysis issue

  Mayyhem

  committed
  b391078

  Copy full SHA for b391078