-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BED-5133 #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benwaples
added
enhancement
New feature or request
user interface
A pull request containing changes affecting the UI code.
labels
Jan 10, 2025
elikmiller
reviewed
Jan 13, 2025
elikmiller
reviewed
Jan 13, 2025
packages/javascript/bh-shared-ui/src/views/DataQuality/DataSelector/types.ts
Show resolved
Hide resolved
elikmiller
approved these changes
Jan 14, 2025
specter-flq
approved these changes
Jan 22, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
enhancement
New feature or request
user interface
A pull request containing changes affecting the UI code.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
Domain
type from api-client and uses a string literal forDomain.type
-platform
options in that component.useAvailableDomains
hook.MappedStringLiteral
which will map all values of a string literal to specified valuesMotivation and Context
Implements BED-5133
How Has This Been Tested?
added unit tests and manually tested
Screenshots (optional):
Types of changes
Checklist: