Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ReadOnlyRootFilesystem, Memory, and CPU Limits #735

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Set ReadOnlyRootFilesystem, Memory, and CPU Limits #735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
215751c
Set webhook_container_security_context_read_only_root_fs.
YouJinTou Jan 4, 2024
238f42d
Added cpu and memory limits to container.
YouJinTou Jan 4, 2024
04b0cc6
adding parameter values
Jan 8, 2024
315f57a
adding os updates to dockerfile; adding parameters to go file
Jan 9, 2024
d1ce0d9
Revert "adding parameter values"
YouJinTou Jul 22, 2024
7c7f04c
Revert "adding os updates to dockerfile; adding parameters to go file"
YouJinTou Jul 22, 2024
147ee49
Added default webhook_container_security_context_read_only_root_fs=fa…
YouJinTou Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cmd/azure-keyvault-secrets-webhook/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,7 @@ func initConfig() {
viper.SetDefault("webhook_container_security_context_read_only", false)
viper.SetDefault("webhook_container_security_context_non_root", false)
viper.SetDefault("webhook_container_security_context_privileged", true)
viper.SetDefault("webhook_container_security_context_read_only_root_fs", false)

viper.AutomaticEnv()
}
Expand Down
19 changes: 19 additions & 0 deletions cmd/azure-keyvault-secrets-webhook/pod.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import (
"strings"

"k8s.io/apimachinery/pkg/api/errors"
"k8s.io/apimachinery/pkg/api/resource"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"

"github.com/SparebankenVest/azure-key-vault-to-kubernetes/cmd/azure-keyvault-secrets-webhook/auth"
Expand Down Expand Up @@ -96,6 +97,24 @@ func (p podWebHook) getInitContainers() []corev1.Container {
Type: corev1.SeccompProfileTypeRuntimeDefault,
}
}
if viper.IsSet("webhook_container_security_context_read_only_root_fs") {
container.SecurityContext.ReadOnlyRootFilesystem = &[]bool{viper.GetBool("webhook_container_security_context_read_only_root_fs")}[0]
}

resourceList := corev1.ResourceList{}
if viper.IsSet(("webhook_container_memory_limit")) {
memory, err := resource.ParseQuantity(viper.GetString("webhook_container_memory_limit"))
if err == nil {
resourceList["memory"] = memory
}
}
if viper.IsSet(("webhook_container_cpu_limit")) {
cpu, err := resource.ParseQuantity(viper.GetString("webhook_container_cpu_limit"))
if err == nil {
resourceList["cpu"] = cpu
}
}
container.Resources.Limits = resourceList

return []corev1.Container{container}
}
Expand Down
Loading