Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernisere skjemaelementer #2461

Merged
merged 4 commits into from
Jan 14, 2025
Merged

Modernisere skjemaelementer #2461

merged 4 commits into from
Jan 14, 2025

Conversation

tuva-odegard
Copy link
Contributor

@tuva-odegard tuva-odegard commented Jan 6, 2025 •
edited
Loading

Som en del av å få et mer moderne utseende i Sparebank1, har vi jobbet med å modernisere komponenter. Denne PRen er for modernisering av skjemaelementer. Kan finnes i DS 2.0 Core i Figma.
https://www.figma.com/design/0trRkHBkdZ6emkhwPJAJMy/DS-2.0-Core---semantiske-farger?node-id=18547-40423

Man kan ignorere fargebruken siden den blir oppdatert med semantiske farger.

Ting å tenke på når man skal teste

  • Focus, hover, Hover on focus, focus med tastatur
  • Error (fieldmessage), error focus osv.
  • Darkmode med alle disse modsene

Alle skjemaelementer er med i denne committen.
image

Tooltip er her en del av Form, men det har kommet inn endringsønsker og det anses som en større greie å endre denne.

Checkbox har ikke fått helt riktig ikon, men det kan også endres på senere.

fixes ##2448

@tuva-odegard tuva-odegard requested a review from a team as a code owner January 6, 2025 13:13
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2461.westeurope.2.azurestaticapps.net

@tuva-odegard tuva-odegard force-pushed the modernisere-skjemaelementer branch 2 times, most recently from 0df41dd to eb6ab42 Compare January 10, 2025 15:12
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2461.westeurope.2.azurestaticapps.net

1 similar comment
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2461.westeurope.2.azurestaticapps.net

@tuva-odegard tuva-odegard changed the title Modernisere skjemaelementer - ikke fullstendig Modernisere skjemaelementer Jan 13, 2025
hagenek
hagenek previously approved these changes Jan 13, 2025
View reviewed changes
dagfrode
dagfrode previously approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@dagfrode dagfrode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Liker at du får fjernet ubrukt styling. Digg å få oppdatert designet, det ser renere ut!

packages/ffe-form-react/package.json Show resolved Hide resolved
@tuva-odegard tuva-odegard dismissed stale reviews from dagfrode and hagenek via 442ba35 January 14, 2025 08:44
@tuva-odegard tuva-odegard force-pushed the modernisere-skjemaelementer branch from 442ba35 to c424090 Compare January 14, 2025 08:45
@tuva-odegard tuva-odegard force-pushed the modernisere-skjemaelementer branch from e3d362a to 0b086ae Compare January 14, 2025 08:48
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2461.westeurope.2.azurestaticapps.net

1 similar comment
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2461.westeurope.2.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2461.westeurope.2.azurestaticapps.net

1 similar comment
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2461.westeurope.2.azurestaticapps.net

@tuva-odegard tuva-odegard merged commit 3c7d6c1 into develop Jan 14, 2025
3 checks passed
@tuva-odegard tuva-odegard deleted the modernisere-skjemaelementer branch January 14, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antidecaf antidecaf antidecaf approved these changes

@dagfrode dagfrode dagfrode left review comments

@hagenek hagenek hagenek left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tuva-odegard @antidecaf @hagenek @dagfrode