feat(ffe-form-react): standardize selectedValue in radio components #2447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2447.westeurope.2.azurestaticapps.net |
pethel
force-pushed
the
develop_fix-input
branch
from
9529a2c to
73be561
Compare
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2447.westeurope.2.azurestaticapps.net |
BREAKING CHANGE: limit selectedValue in radio komponents to string, null, undefined.
pethel
force-pushed
the
develop_fix-input
branch
from
73be561 to
97f596d
Compare
pethel
commented
Dec 17, 2024
| <RadioBlock | ||
| {...inputProps} | ||
| label="Ja" | ||
| value="yes" | ||
| // @ts-ignore |
There was a problem hiding this comment.
Her har vi buggen også i dokumentasjonen
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2447.westeurope.2.azurestaticapps.net |
antidecaf
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provar standardisera typerna på radio komponenterna da vi har en bug der typerna ikke sammensvarer. Jag synes vi kan begrensa oss til strings(i onChange så får man ett vanlig event bare med stringen på e.target.value), null og undefined.
fixes: #2442