Develop illustration card icon right #2213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pethel
commented
Aug 20, 2024
|
|
||
| describe('IconCard', () => { | ||
| it('should render correct class and contain a div with body class', () => { | ||
| render( | ||
| <IconCard | ||
| data-testid={TEST_ID} | ||
| as="li" |
There was a problem hiding this comment.
Disse vill ofta vare listelement så synes dette blir bedre.
pethel
commented
Aug 20, 2024
| @@ -13,288 +15,6 @@ const illustration = ( | |||
| fill="none" | |||
| aria-hidden={true} | |||
| > | |||
| <path | |||
There was a problem hiding this comment.
Vi trener ikke så svær illustrasjon i testen :)
pethel
commented
Aug 20, 2024
| } | ||
|
|
||
| @media (min-width: @breakpoint-md) { | ||
| .ffe-icon-card__icon { | ||
| margin: 0 var(--ffe-spacing-md) 0; | ||
| gap: var(--ffe-spacing-md); |
There was a problem hiding this comment.
Bruker gap istellet før margins
pethel
force-pushed
the
develop_illustration-card-icon-right
branch
from
dc1c602 to
ec9dea5
Compare
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2213.westeurope.2.azurestaticapps.net |
tuva-odegard
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mulighet før att ha illustrasjonen på høyre sida i illustration card.
Retter noen småfeil i icon card også. Ikonet skall gå helt ut mot kanten når den ligger til høyre.