Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ffe-searchable-dropdown-react): aria-selected #2208

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

pethel
Copy link
Contributor

@pethel pethel commented Aug 16, 2024

Aria selected skall kun vare true når ett element faktiskt er valgt og ikke hare har focus.

@pethel pethel marked this pull request as ready for review August 16, 2024 09:08
@pethel pethel requested a review from a team as a code owner August 16, 2024 09:08
Only when actually selected aria-selected should be true.
Not when item in list is highlighted.
@pethel pethel force-pushed the develop_fix-searchable-dropdown branch from 476eddc to 6177830 Compare August 16, 2024 09:12
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2208.westeurope.2.azurestaticapps.net

Copy link
Contributor

@tuva-odegard tuva-odegard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Godkjenner med forbehold om at @SindreSafvenbom godkjenner. Ikke merge før han har fått sett på det

@pethel pethel merged commit 1b99f6b into develop Aug 16, 2024
3 checks passed
@pethel pethel deleted the develop_fix-searchable-dropdown branch August 16, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants