Ønskeliste: Illustration card #2136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2136.westeurope.2.azurestaticapps.net |
pethel
reviewed
Jun 30, 2024
| fill="#7EB5D2" | ||
| /> | ||
| </g> | ||
| <defs> |
There was a problem hiding this comment.
Tror du kan fjerne denne og den ur eksemplet. Blir mindre komplisert og bølgeeksemplet hade en bug pga av samme kode.
There was a problem hiding this comment.
Skjønner ikke helt hva du mener? Fjerne <defs> og hva?
There was a problem hiding this comment.
Blir seendes feil ut hvis jeg fjerner defs
There was a problem hiding this comment.
OK da kan du la de ligge. Hvis du fjerner g også?
pethel
reviewed
Jun 30, 2024
pethel
reviewed
Jun 30, 2024
pethel
reviewed
Jun 30, 2024
pethel
reviewed
Jun 30, 2024
tuva-odegard
force-pushed
the
develop-illustration-card
branch
from
e9fb020 to
0960089
Compare
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2136.westeurope.2.azurestaticapps.net |
pethel
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Legger til
IllustrationCardsom et alternativrelatert til #2117
Beskrivelse
IconCard støttet ikke en illustrasjon, så vi besluttet å lage et eget kort for dette.
Det ble også oppdaget at StipledCard støtter my av det de andre kortene støtter, og at vi kanskje burde ha dette som et valg på de andre kortene i stedet for.
Det ble diskutert å ha et "Card to rule them all", altså at kun ett kort kan ta inn img, icon, stipled:boolean osv, men vi konkludrte med at det er lettere å holde de separat.
Testing
De nye variantene heter
<IllustrationCard>og illustrationcard condensed. Dokumentasjon kommer.