Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: less variables -> css custom properties #2135

Merged
merged 10 commits into from
Jul 10, 2024
Merged

refactor: less variables -> css custom properties #2135

merged 10 commits into from
Jul 10, 2024

Conversation

pethel
Copy link
Contributor

@pethel pethel commented Jun 28, 2024

No description provided.

@pethel pethel marked this pull request as ready for review June 28, 2024 14:08
@pethel pethel requested a review from a team as a code owner June 28, 2024 14:08
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2135.westeurope.2.azurestaticapps.net

tuva-odegard
tuva-odegard reviewed Jun 30, 2024
View reviewed changes
Copy link
Contributor

@tuva-odegard tuva-odegard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Må ikke dette være flere forskjellige commits? Eller har det ikke noe å si når det er css?

@pethel
Copy link
Contributor Author

pethel commented Jul 1, 2024 •
edited
Loading

Må ikke dette være flere forskjellige commits? Eller har det ikke noe å si når det er css?

Man kommer få en version ny version av pakkene som endret. Lite osikker på vad endringen blir i CHANGELOG. Det kan blir

**Note:** Version bump only for package @sb1/ffe-....

Eller så kan det meldningen jag skrev i den ena commiten. Jag har lust og testa da dette ikke burde brekke noe. Det er ju en ikke funksjonell endringen

@pethel pethel requested a review from tuva-odegard July 1, 2024 06:51
@HeleneKassandra
Copy link
Contributor

Jeg ville ha laget flere commits, det er sånn vi har gjort det hele veien for å sikre at pakkene faktisk blir bumpet. Tror den
**Note:** Version bump only for package @sb1/ffe-.... er kun for pakkene som har en dependency til en annen pakke som er "targeted" av en commit.

Så hvis du har "fix(ffe-buttons):" så vil alle pakkene som har en dependency til ffe-buttons få den meldingen.

Veldig fint med gode commitmeldinger på alle pakkene, da CHANGELOG.md filene er hvertfall min hovedkilde å se på når jeg bumper ffe.

@pethel pethel force-pushed the develop_fjern-kommentarer-i-css branch 3 times, most recently from e60e353 to 0279d88 Compare July 10, 2024 05:59
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2135.westeurope.2.azurestaticapps.net

@pethel pethel force-pushed the develop_fjern-kommentarer-i-css branch 8 times, most recently from 0811376 to 315847e Compare July 10, 2024 06:17
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2135.westeurope.2.azurestaticapps.net

@pethel pethel force-pushed the develop_fjern-kommentarer-i-css branch from 315847e to 15ca6d7 Compare July 10, 2024 06:22
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2135.westeurope.2.azurestaticapps.net

@pethel
Copy link
Contributor Author

pethel commented Jul 10, 2024

Må ikke dette være flere forskjellige commits? Eller har det ikke noe å si når det er css?

Nu har jag endret til en commit per pakke

@pethel
Copy link
Contributor Author

pethel commented Jul 10, 2024

Jeg ville ha laget flere commits, det er sånn vi har gjort det hele veien for å sikre at pakkene faktisk blir bumpet. Tror den **Note:** Version bump only for package @sb1/ffe-.... er kun for pakkene som har en dependency til en annen pakke som er "targeted" av en commit.

Så hvis du har "fix(ffe-buttons):" så vil alle pakkene som har en dependency til ffe-buttons få den meldingen.

Veldig fint med gode commitmeldinger på alle pakkene, da CHANGELOG.md filene er hvertfall min hovedkilde å se på når jeg bumper ffe.

Nu har jag endret til en commit per pakke

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2135.westeurope.2.azurestaticapps.net

@pethel pethel merged commit 3645b3f into develop Jul 10, 2024
3 checks passed
@pethel pethel deleted the develop_fjern-kommentarer-i-css branch July 10, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeleneKassandra HeleneKassandra HeleneKassandra approved these changes

@tuva-odegard tuva-odegard Awaiting requested review from tuva-odegard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pethel @HeleneKassandra @tuva-odegard