Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop fix modal shadow dom #2115

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Develop fix modal shadow dom #2115

merged 2 commits into from
Jun 25, 2024

Conversation

pethel
Copy link
Contributor

@pethel pethel commented Jun 25, 2024

No description provided.

@pethel pethel marked this pull request as ready for review June 25, 2024 09:31
@pethel pethel requested a review from a team as a code owner June 25, 2024 09:31
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2115.westeurope.2.azurestaticapps.net

tuva-odegard
tuva-odegard approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@tuva-odegard tuva-odegard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Føler ikke jeg har no kkunnskap til å vite alt hva dette gjør/imkliasjoner, men koden ser ritkig ut i alle fall

@pethel
Copy link
Contributor Author

pethel commented Jun 25, 2024

Føler ikke jeg har no kkunnskap til å vite alt hva dette gjør/imkliasjoner, men koden ser ritkig ut i alle fall

Dette er før att bakgrundne ikke skall få scroll medans modalen er open. VI trenger kun og gjøre dette når vi er i shadow dom eftersom cssen vår ikke fungerer da.

Planen er

  1. Når man opner modalen ta tilvara på overflowY som er på html hvis det er noen fra før i en temp.
  2. Sett overflow-y hidden på html slik att man ikke får scroll bak modalen
  3. Når man lukker modalen sett tillbake overflowY som man tok tilvare på i temp i punkt1.

Dette er kun nødvendig i shadow dom. Når vi ikke er i shadowdom funker allt med vanlig css.

@pethel pethel merged commit c3cdcc3 into develop Jun 25, 2024
3 checks passed
@pethel pethel deleted the develop_fix-modal-shadow-dom branch June 25, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuva-odegard tuva-odegard tuva-odegard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pethel @tuva-odegard