Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop modal #2100

Merged
merged 3 commits into from
Jun 21, 2024
Merged

Develop modal #2100

merged 3 commits into from
Jun 21, 2024

Conversation

pethel
Copy link
Contributor

@pethel pethel commented Jun 20, 2024

Førsta utkast til modalen.

  • UU testad
  • Trenger en sista design QA

@pethel pethel marked this pull request as ready for review June 20, 2024 15:00
@pethel pethel requested a review from a team as a code owner June 20, 2024 15:00
ref={modalRef}
className={classnames('ffe-body', 'ffe-modal', className)}
aria-labelledby={ariaLabelledby}
onClick={event => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Det er før att lukka den hvis man clicker utanfør modalen.

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2100.westeurope.2.azurestaticapps.net

@pethel pethel force-pushed the develop_modal branch 2 times, most recently from 41bb0a4 to bcaf6dc Compare June 20, 2024 18:33
import { Modal } from './Modal';
import { render, screen } from '@testing-library/react';

describe('<SystemMessage />', () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lite vad begresent vad man får testet. dialog.showModal er ikke støttat av jsdom. Jag bruker hidden når jag spør efter elementerna. Det betyr att dom egentligen ikke er accessible. Det er dom ju ikek fordi jag har ikke opnet modalen enda. INgen mulighet att opne i jsdom som jag først provade meg på.

@pethel pethel force-pushed the develop_modal branch 2 times, most recently from 1974db2 to 3a6dac0 Compare June 21, 2024 06:28
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2100.westeurope.2.azurestaticapps.net

@pethel pethel force-pushed the develop_modal branch 2 times, most recently from baaadea to df4e003 Compare June 21, 2024 07:29
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2100.westeurope.2.azurestaticapps.net

1 similar comment
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2100.westeurope.2.azurestaticapps.net

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2100.westeurope.2.azurestaticapps.net

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2100.westeurope.2.azurestaticapps.net

@antidecaf
Copy link
Contributor

Ser bra ut! La inn litt pirk og et forslag til transition på lukkeknappen, bare for at den skal oppleves litt mykere på hover.

@pethel pethel requested a review from antidecaf June 21, 2024 13:01
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2100.westeurope.2.azurestaticapps.net

@pethel pethel merged commit 4c0b529 into develop Jun 21, 2024
3 checks passed
@pethel pethel deleted the develop_modal branch June 21, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants