fix(ffe-core): utvide breakpoint for typografi på tablets #2073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jag føler @antidecaf må ta denne. Jag kjenner en så lenge ikke typografin gott nok før att si hvordan det henger sammen og vill påvreka ting det her. |
tuva-odegard
changed the title
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2073.westeurope.2.azurestaticapps.net |
antidecaf
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1403
Beskrivelse
Breakpointet for tablets var litt for lite til å også tilrettelegge for landscape mode. Før denne committen fikk vi mindre skriftstørrelse på h1, h2 og h3 ved breakpoint-md (768px), men i følge microsoft kan landscape tablets være opp mot 1008px.
Har nå satt det til breakpoint-lg (1024px), så litt høyere enn microsoft sin standard, men tenker det er bedre at vi er konsistente i bruken av breakpoints internt. Så, fra 1023px og nedover så er skriftstørrelsen for h1, h2 og h3 litt mindre. Håper at det blir bedre for flere.
Vi nevner ikke typografi-breakpoints i dokumentasjonen så det trengs ikke oppdateres noe i designssystem-docs.
Testing
https://sparebank1.github.io/designsystem/typography_Heading sjekk på forskjellige skjermsørrelser.