Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(component-overview): keep scroll position when navigation back #2062

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

pethel
Copy link
Contributor

@pethel pethel commented Jun 6, 2024

Fikser tilbake navigasjonen når man navigerer fram og tilbake mellom komponenter og bumper react router i samem slengen

@pethel pethel requested a review from a team as a code owner June 6, 2024 06:18
@pethel pethel requested a review from HeleneKassandra June 6, 2024 06:19
@@ -1,6 +1,5 @@
/* stylelint-disable selector-class-pattern */
.sb1ex-page {
height: 100vh;
Copy link
Contributor Author

@pethel pethel Jun 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Det her var banditen som gjorde att det ikke funket

Copy link
Contributor

@antidecaf antidecaf Jun 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kanskje den kan erstattes med min-height: 100%; eller noe sånt i stedet for å fjernes helt? Det burde i teorien gå bra siden min-height ikke er statisk.
Når .sb1ex-page ikke er 100% høy funker ikke toggling av bakgrunnsfarge helt som det skal.

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

min-height: 100% ser ut som det virker som forventet, enig!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

min-height: 100% kjørde jag på. Funker bra tror jag

Copy link

github-actions bot commented Jun 6, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2062.westeurope.2.azurestaticapps.net

Copy link

github-actions bot commented Jun 6, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2062.westeurope.2.azurestaticapps.net

Copy link

github-actions bot commented Jun 6, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2062.westeurope.2.azurestaticapps.net

@pethel pethel merged commit 99e55b2 into develop Jun 6, 2024
3 checks passed
@pethel pethel deleted the se-pa-nav branch June 6, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants