Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ny detail list card komponent #1832

Merged
merged 3 commits into from
Mar 25, 2024
Merged

Ny detail list card komponent #1832

merged 3 commits into from
Mar 25, 2024

Conversation

HeleneKassandra
Copy link
Contributor

Beskrivelse

Legger til ny komponent som heter DetailListCard.
Skjermbilde 2024-03-11 kl 09 15 48

Motivasjon og kontekst

Denne komponenten finnes mange steder i mange ulike applikasjoner, så tok på meg jobben med å endelig få den inn som en komponent i designsystemet.

Komponenten brukes til å vise informasjon, og det finnes mange ulike varianter der man noen ganger har klikkbare rader og andre ganger ikke.

Testing

Kjørt opp lokalt i component overview.

@HeleneKassandra HeleneKassandra requested a review from pethel March 12, 2024 08:14
@HeleneKassandra HeleneKassandra force-pushed the ny-detailListCard-komponent branch from 0c6b221 to e925870 Compare March 12, 2024 08:19
@HeleneKassandra
Copy link
Contributor Author

Denne er forsatt WIP! Men setter den til "ready for review" sånn at Andrea og Sindre kan teste UU via Azure / Component-overview

@HeleneKassandra HeleneKassandra marked this pull request as ready for review March 12, 2024 11:20
@HeleneKassandra HeleneKassandra requested a review from a team as a code owner March 12, 2024 11:20
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1832.westeurope.2.azurestaticapps.net

1 similar comment
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1832.westeurope.2.azurestaticapps.net

@HeleneKassandra HeleneKassandra force-pushed the ny-detailListCard-komponent branch from 6099d3f to fa4d9a6 Compare March 13, 2024 12:17
@HeleneKassandra HeleneKassandra requested a review from pethel March 13, 2024 12:18
@HeleneKassandra HeleneKassandra changed the title WIP: Ny detail list card komponent Ny detail list card komponent Mar 13, 2024
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1832.westeurope.2.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1832.westeurope.2.azurestaticapps.net

1 similar comment
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1832.westeurope.2.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1832.westeurope.2.azurestaticapps.net

1 similar comment
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1832.westeurope.2.azurestaticapps.net

@HeleneKassandra HeleneKassandra force-pushed the ny-detailListCard-komponent branch from fef03af to dcc2d0f Compare March 21, 2024 11:35
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1832.westeurope.2.azurestaticapps.net

1 similar comment
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1832.westeurope.2.azurestaticapps.net

pethel
pethel suggested changes Mar 21, 2024
View reviewed changes
packages/ffe-lists-react/src/DetailListCardItem.js Outdated Show resolved Hide resolved
packages/ffe-lists-react/src/DetailListCardItem.js Show resolved Hide resolved
packages/ffe-lists-react/src/DetailListCardItem.js Outdated Show resolved Hide resolved
packages/ffe-lists-react/src/DetailListCard.spec.js Outdated Show resolved Hide resolved
packages/ffe-lists-react/src/DetailListCard.spec.js Outdated Show resolved Hide resolved
packages/ffe-lists-react/src/DetailListCard.spec.js Outdated Show resolved Hide resolved
packages/ffe-lists-react/src/index.d.ts Outdated Show resolved Hide resolved
packages/ffe-lists-react/src/index.d.ts Outdated Show resolved Hide resolved
packages/ffe-lists-react/src/index.d.ts Outdated Show resolved Hide resolved
packages/ffe-lists/less/detail-list-card.less Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1832.westeurope.2.azurestaticapps.net

@HeleneKassandra HeleneKassandra requested a review from pethel March 22, 2024 11:41
pethel
pethel approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@pethel pethel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ser bra ut før meg nå!

pethel
pethel reviewed Mar 23, 2024
View reviewed changes
Copy link
Contributor

@pethel pethel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commitsen burde vell også ryddas op i. En commit per pakke

@HeleneKassandra HeleneKassandra force-pushed the ny-detailListCard-komponent branch from 078101a to ba78958 Compare March 25, 2024 09:59
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1832.westeurope.2.azurestaticapps.net

@HeleneKassandra HeleneKassandra merged commit c4dd7bd into develop Mar 25, 2024
4 checks passed
@HeleneKassandra HeleneKassandra deleted the ny-detailListCard-komponent branch March 25, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pethel pethel pethel approved these changes

@antidecaf antidecaf Awaiting requested review from antidecaf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HeleneKassandra @antidecaf @pethel