fix(ffe-core): add missing css custom props to theme.less #1828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antidecaf
reviewed
Mar 7, 2024
|
Takk for at du har gjort denne jobben! La inn en liten kommentar på importer som er lagt inn, ellers ser det topp ut. :) |
a504aa1
force-pushed
the
add-missing-css-custom-props
branch
from
a277367 to
fb9e78f
Compare
antidecaf
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beskrivelse
Har lagt til css custom props for breakpoints, dimensions, motion og spacing. Disse eksisterte kun som less variabler tidligere.
Motivasjon og kontekst
Løser #1823.
Løser problem med manglende padding i Accordion pga bruk av --ffe-spacing-xs fremfor @ffe-spacing-xs.
Testing