Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ffe-system-message-react): use locale for translations #1819

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

pethel
Copy link
Contributor

@pethel pethel commented Mar 4, 2024

localen ble ikke bruykt til annet en lukkknappen her.

burde locale vare required?

@pethel pethel requested a review from a team as a code owner March 4, 2024 12:01
Copy link

github-actions bot commented Mar 4, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1819.westeurope.2.azurestaticapps.net

@HeleneKassandra
Copy link
Contributor

Litt usikker på om det bør være required eller ikke. Alle team internt vil nok bruke locale, og da er det vil det være greit at man ikke glemmer det, men vet ikke hvordan det er for team utenfor om de har samme krav til språk

@pethel
Copy link
Contributor Author

pethel commented Mar 5, 2024

Litt usikker på om det bør være required eller ikke. Alle team internt vil nok bruke locale, og da er det vil det være greit at man ikke glemmer det, men vet ikke hvordan det er for team utenfor om de har samme krav til språk

Ja det er akkurat det. Ikke sikkert folke skjønner att det er skjulta texter som burde vare riktigt oversatt.

@pethel pethel merged commit 91b7ee5 into develop Mar 5, 2024
4 checks passed
@pethel pethel deleted the develop_fix-system-message-translations branch March 5, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants