Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ffe-form): wrong heigth tooltip #1817

Merged
merged 2 commits into from
Mar 4, 2024
Merged

fix(ffe-form): wrong heigth tooltip #1817

merged 2 commits into from
Mar 4, 2024

Conversation

pethel
Copy link
Contributor

@pethel pethel commented Mar 4, 2024

Må ha telt feil/ikke telt forste gang?
Denne var iaf hardkodet til 25px før jag begynnte og fixa så att den skulle tåla text zoom.

@pethel pethel requested a review from a team as a code owner March 4, 2024 10:44
@pethel pethel force-pushed the develop_fix-tooltip branch from 86efdfb to 39575f8 Compare March 4, 2024 10:44
@@ -6,7 +6,7 @@
border: 2px solid var(--ffe-v-tooltip-border-color);
color: var(--ffe-v-tooltip-icon-color);
cursor: help;
height: 1.2rem;
height: 1.5625rem;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

25/16

Copy link

github-actions bot commented Mar 4, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1817.westeurope.2.azurestaticapps.net

1 similar comment
Copy link

github-actions bot commented Mar 4, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1817.westeurope.2.azurestaticapps.net

@pethel pethel force-pushed the develop_fix-tooltip branch 2 times, most recently from 8852977 to 16d9acd Compare March 4, 2024 11:00
Copy link

github-actions bot commented Mar 4, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1817.westeurope.2.azurestaticapps.net

1 similar comment
Copy link

github-actions bot commented Mar 4, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1817.westeurope.2.azurestaticapps.net

@@ -86,7 +86,7 @@ export interface TooltipProps extends React.ComponentProps<'span'> {
isOpen?: boolean;
onClick?: (e: React.MouseEvent | undefined) => void;
tabIndex?: number;
ref?: React.Ref<HTMLButtonElement>;
ref?: React.ForwardedRef<HTMLButtonElement>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For at denne endringen skal publiseres til npm må den skilles ut i en egen commit, siden dette er i ffe-form-react og ikke ffe-form.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ja stemmer. skall ordne

@pethel pethel force-pushed the develop_fix-tooltip branch from 16d9acd to 5e3374b Compare March 4, 2024 12:59
@pethel pethel requested a review from antidecaf March 4, 2024 12:59
@pethel pethel force-pushed the develop_fix-tooltip branch from 5e3374b to 09ae671 Compare March 4, 2024 13:02
Copy link

github-actions bot commented Mar 4, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1817.westeurope.2.azurestaticapps.net

1 similar comment
Copy link

github-actions bot commented Mar 4, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1817.westeurope.2.azurestaticapps.net

@pethel pethel merged commit f0d1f06 into develop Mar 4, 2024
4 checks passed
@pethel pethel deleted the develop_fix-tooltip branch March 4, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants