Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(component-overview): legg til ffe-icons som bundleddependency #1755

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

HeleneKassandra
Copy link
Contributor

@HeleneKassandra HeleneKassandra commented Jan 19, 2024

Beskrivelse

Legger til ffe-icons pakken som bundleddependency

Motivasjon og kontekst

Vi får byggfeil i dokumentasjonen, fordi vi i 2 eksempler henter inn ikoner fra component-index pakken sinnode_modules/@sb1/ffe-icons/[..] denne pathen eksisterer ikke da npm installerer alle dependencys på høyere nivå. Denne endringen gjør at den installerer sb1-ffe-icons under node_modules i component-index pakken, sånn at pathen eksisterer.

Håpet er at det retter byggfeilen i docs

Testing

Kjørt npm install

@HeleneKassandra HeleneKassandra requested a review from a team as a code owner January 19, 2024 14:30
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1755.westeurope.2.azurestaticapps.net

@HeleneKassandra HeleneKassandra merged commit c0feee3 into develop Jan 22, 2024
4 checks passed
@HeleneKassandra HeleneKassandra deleted the bundle-ffe-icons-dep branch January 22, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants