Tommel fra svgr-komponenter i ffe-feedback #1746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isakbjugn
force-pushed
the
tommel-fra-svgr-komponenter
branch
from
abab221 to
4db5a58
Compare
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1746.westeurope.2.azurestaticapps.net |
isakbjugn
force-pushed
the
tommel-fra-svgr-komponenter
branch
from
4db5a58 to
201c34a
Compare
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1746.westeurope.2.azurestaticapps.net |
HeleneKassandra
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beskrivelse
Bytter tomler fra
@sb1/ffe-symbols-reactmed SVG-filer direkte fra Material Icons, som er konvertert til React-komponenter mednpx @svgr/cli. Tommel med/uten fyll blir nå satt basert påhover-pseudoklassen i CSS.Ingen visuelle endringer.
Motivasjon og kontekst
Tidligere implementasjon brukte ikoner gjennom Material Symbols-typen, og vekslet mellom vanlig/fylt type gjennom å endre klassenavn ved
onHover. Denne løsningen var skjør, og førte til at ikoner skjultes eller flyttet på seg ved førsteonHovereller førfill-skrifttypen var ferdig lastet. Den nye løsningen krever ikke at skrifttyper lastes.Testing
Testet manuelt at det ikke er visuelle endringer eller funksjonsendringer.