Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ffe-icons): lagrer alle relevante varianter av symbols som svg #1737

Closed
wants to merge 4 commits into from
Closed

feat(ffe-icons): lagrer alle relevante varianter av symbols som svg #1737

wants to merge 4 commits into from

Conversation

HeleneKassandra
Copy link
Contributor

WIP

Beskrivelse

Laget scripts for å hente alle og lagre alle relevante varianter av symbolene som svg i mapper.

Motivasjon og kontekst

For SVG implementasjon av material symbols

Testing

@HeleneKassandra HeleneKassandra force-pushed the svg-implementation-of-symbols branch from 2f0fa29 to 8e52177 Compare December 6, 2023 13:45
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1737.westeurope.2.azurestaticapps.net

3 similar comments
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 8, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1737.westeurope.2.azurestaticapps.net

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 8, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1737.westeurope.2.azurestaticapps.net

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1737.westeurope.2.azurestaticapps.net

@HeleneKassandra HeleneKassandra force-pushed the svg-implementation-of-symbols branch 2 times, most recently from d832935 to 8840a8d Compare December 11, 2023 08:44
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1737.westeurope.2.azurestaticapps.net

1 similar comment
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1737.westeurope.2.azurestaticapps.net

@HeleneKassandra HeleneKassandra marked this pull request as ready for review December 11, 2023 09:07
@HeleneKassandra HeleneKassandra requested a review from a team as a code owner December 11, 2023 09:07
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1737.westeurope.2.azurestaticapps.net

@HeleneKassandra
Copy link
Contributor Author

HeleneKassandra commented Dec 13, 2023 •
edited
Loading

React komponenten gjenstår før vi har løst ikon problematikken.
Dette er noen feil/utfordringer jeg vet om per nå:

  • Noen ikon-navn starter på tall, og det er ikke gyldig som const-navn. Må derfor ha en prefix eller noe som unngår denne feilen. Hva skal den prefixen være? "ffe"?
  • Hvordan skal react komponenten være? Forskjellen fra gamle ffe-icons-react er at vi nå har flere versjoner av samme ikon / med samme navn. Så hvordan setter man weight, fill, og størrelse? Og hvordan skal man sette farge på ikonet.

@HeleneKassandra HeleneKassandra force-pushed the svg-implementation-of-symbols branch 4 times, most recently from 12174e3 to 615e19f Compare December 18, 2023 16:15
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1737.westeurope.2.azurestaticapps.net

7 similar comments
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1737.westeurope.2.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1737.westeurope.2.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1737.westeurope.2.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1737.westeurope.2.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1737.westeurope.2.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1737.westeurope.2.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1737.westeurope.2.azurestaticapps.net

jberglund
jberglund reviewed Dec 20, 2023
View reviewed changes
packages/ffe-icons/less/icons.less Outdated
@@ -0,0 +1,23 @@
.ffe-icons {
fill: var(--ffe-v-icons-default-color);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kanske sätta

height: var(--ffe-icon-size);
width: var(--ffe-icon-size);
fill: var(--ffe-icon-override-color, var(--ffe-v-icons-default-color)); 
   &--sm {
        --ffe-v-icon-size: var(--ffe-v-icons-size-sm, 20px);
    }
   // ... och så vidare
}

Copy link

@jberglund jberglund Dec 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Då får man ett sätt att överstyra färgen som inte är att överskriva en variabel som heter "default" :)
Och att definiera width/height på den högsta selectorn och sedan sätta nya variabler gör det enklare att förstå att det är just .ffe-icons som ska ha reglerna. Tar man bort ffe-icons--sm så får den ju heller ingen width/height om de sitter på just den klassen
.

@HeleneKassandra HeleneKassandra force-pushed the svg-implementation-of-symbols branch from 2119d98 to 4ad756b Compare December 20, 2023 12:36
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1737.westeurope.2.azurestaticapps.net

2 similar comments
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1737.westeurope.2.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1737.westeurope.2.azurestaticapps.net

@HeleneKassandra HeleneKassandra force-pushed the svg-implementation-of-symbols branch from 1865398 to 22bd2ae Compare January 3, 2024 14:46
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1737.westeurope.2.azurestaticapps.net

@HeleneKassandra HeleneKassandra marked this pull request as draft January 3, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jberglund jberglund jberglund left review comments

@kwltrs kwltrs kwltrs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HeleneKassandra @kwltrs @jberglund