Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Legg til typescript typings for symbols #1696

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Legg til typescript typings for symbols #1696

merged 1 commit into from
Nov 3, 2023

Conversation

HeleneKassandra
Copy link
Contributor

@HeleneKassandra HeleneKassandra commented Nov 1, 2023 •
edited
Loading

Beskrivelse

  • Legger til "fetchSymbolNames" script som henter alle ikon navnene fra material symbols fra font codepoints i det offisielle repoet.
  • Legger til"generateSymbolTypings.js" som tar alle ikon navnene fra "fetchSymbolNames" og lager en liste i format et som brukes i typescript typings og legger dette i en separat fil som heter "symbolNames.ts".
  • Importerer "symbolNames.ts" i index.d.ts i typingsene.

Note: Har manuelt gått gjennom og fjernet alle navnene på ikonene som ble lagt til i Material Symbols etter vi la til font-filene. Det vil si at alle ikonene som ligger i typings skal finnes i font-filene som ligger i ffe-symbols. Ikoner som blir fjernet etter versjonen i ffe-symbols er heller ikke med, da det ikke er noe vits å ta i bruk ikoner som uansett blir fjernet.

  • Har ikke lagt inn typings i react, da lista visstnok vil bli veldig stor i bundle.

Man kan se alle endringer som blir gjort i material symbols her: https://material-symbols-changelog.vercel.app/
(font-filene i ffe-symbols ble sist oppdatert 29.august)

Takk til @pethel for god hjelp underveis! :D

Motivasjon og kontekst

Legger til typescript typings på ikon-navn sånn at det forhåpentligvis blir lettere for utviklere å finne riktig ikon-navn og vite hvilke ikoner som er tilgjengelig.

Etterspurt på slack.

Testing

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1696.westeurope.2.azurestaticapps.net

@HeleneKassandra HeleneKassandra force-pushed the symbols-typings branch 3 times, most recently from b60ba3e to bf2fa5b Compare November 1, 2023 15:01
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1696.westeurope.2.azurestaticapps.net

2 similar comments
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1696.westeurope.2.azurestaticapps.net

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1696.westeurope.2.azurestaticapps.net

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1696.westeurope.2.azurestaticapps.net

@HeleneKassandra HeleneKassandra changed the title WIP: Symbols typings Legg til typescript typings for symbols Nov 2, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1696.westeurope.2.azurestaticapps.net

@HeleneKassandra HeleneKassandra marked this pull request as ready for review November 2, 2023 18:22
@HeleneKassandra HeleneKassandra requested a review from a team as a code owner November 2, 2023 18:22
@HeleneKassandra
fix(ffe-symbols-react): legg til typings for symbol
2a93040 
BREAKING CHANGE: I forrige versjon som ble feilmarkert som minor.
Endringen innebærer at symbolnavn settes via ikon-prop og ikke children-prop.
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1696.westeurope.2.azurestaticapps.net

@HeleneKassandra HeleneKassandra merged commit 25656f8 into develop Nov 3, 2023
3 checks passed
@HeleneKassandra HeleneKassandra deleted the symbols-typings branch November 3, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hdaljord hdaljord hdaljord approved these changes

@antidecaf antidecaf antidecaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HeleneKassandra @antidecaf @hdaljord