Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bytter ut ikonene i alle komponenter #1661

Closed
wants to merge 38 commits into from

Conversation

HeleneKassandra
Copy link
Contributor

Beskrivelse

Bytter ut alle de gamle ikonene fra ffe-icons-react og ffe-icons til de nye pakkene: ffe-symbols og ffe-symbols-react.

I mange tilfeller så innebærer endringene at brukere nå sender inn en string med navn på ikon, istedenfor å sende med selve ikonet som ett element. Endringene vil også kreve at brukerne importerer ikon-fonten.

Motivasjon og kontekst

Vi går over til å bruke material symbols

Testing

@HeleneKassandra HeleneKassandra force-pushed the update-icons-in-components branch 2 times, most recently from cac710e to 678aacd Compare August 22, 2023 13:25
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1661.westeurope.2.azurestaticapps.net

2 similar comments
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1661.westeurope.2.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1661.westeurope.2.azurestaticapps.net

@HeleneKassandra HeleneKassandra force-pushed the update-icons-in-components branch from dde1c2b to 8b207fb Compare August 22, 2023 15:09
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1661.westeurope.2.azurestaticapps.net

@HeleneKassandra HeleneKassandra force-pushed the update-icons-in-components branch 2 times, most recently from 76701cf to fc161fa Compare August 25, 2023 08:12
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1661.westeurope.2.azurestaticapps.net

1 similar comment
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1661.westeurope.2.azurestaticapps.net

@HeleneKassandra HeleneKassandra force-pushed the update-icons-in-components branch from 0bef874 to fc161fa Compare August 28, 2023 12:34
BREAKING CHANGE: Endre fra fill til color på ikon pga nye ikoner
BREAKING CHANGE: endrer hvordan man sender med ikon. Fjerner leftIcon på shortcutbutton
BREAKING CHANGE: fjerner ikon fra backButton definert i css og
legger til klasse for toggling i inlineExpandButton++
@HeleneKassandra HeleneKassandra force-pushed the update-icons-in-components branch from 760707e to 9bfc446 Compare August 29, 2023 17:08
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1661.westeurope.2.azurestaticapps.net

@HeleneKassandra HeleneKassandra force-pushed the update-icons-in-components branch from 3b0da8c to 00d2eb1 Compare September 1, 2023 15:23
@github-actions
Copy link

github-actions bot commented Sep 1, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1661.westeurope.2.azurestaticapps.net

2 similar comments
@github-actions
Copy link

github-actions bot commented Sep 1, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1661.westeurope.2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Sep 1, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1661.westeurope.2.azurestaticapps.net

HeleneKassandra and others added 7 commits September 19, 2023 14:36
BREAKING CHANGE: BaseMessage legger til props-spesifikt for Symbol-komponenten,
fjerner depedency til ffe-icons-react og legger til ffe-symbols-react
BREAKING CHANGE: Ikonfarge settes nå gjennom color og ikke fill.
Fjerner også referanse til SVG som ikke lenger brukes.
BREAKING CHANGE: Endrer fra fill til color, fjerner svg-relatert styling
BREAKING CHANGE: fjerner color-prop da styling skal skje gjennom css
HeleneKassandra and others added 12 commits September 19, 2023 14:36
BREAKING CHANGE: endrer måten vi setter farge på ikon fra fill til color
Bytter ut ikonene med ikoner fra ffe-symbols. Det betyr at ffe-icons-react
fjernes som dependency og ffe-symbols-react legges til
AccountSelectorHighCapacity depends on SearchableDropdownHighCapacity
from ffe-searchable-dropdown-react, which depends on
react-virtualization; a package which is no longer maintained and
does not work seamlessly with modern build tools such as vite.

If high capacity is still needed, use AccountSelectorMulti or
BaseSelector with prop highCapacity=true.

BREAKING CHANGE: AccountSelectorHighCapacity is no longer exported.
Use AccountSelectorMulti or BaseSelector with prop highCapacity=true
…apacity

SearchableDropdownHighCapacity depends on react-virtualization;
a package which is no longer maintained and does not work
seamlessly with modern build tools such as vite.

BREAKING CHANGE: SearchableDropdownHighCapacity is no longer exported.
@HeleneKassandra HeleneKassandra force-pushed the update-icons-in-components branch from 16ecbca to d21ed5d Compare September 19, 2023 12:44
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1661.westeurope.2.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1661.westeurope.2.azurestaticapps.net

BREAKING CHANGE: endrer fra fill til color, fjerner størrelse og top margins
@HeleneKassandra HeleneKassandra force-pushed the update-icons-in-components branch from 3c84256 to df03a61 Compare September 20, 2023 12:43
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1661.westeurope.2.azurestaticapps.net

BREAKING CHANGE: Endrer fra ffe-icons-react til ffe-symbols-react
endringen innebærer at man må bytte ut hvilke ikoner man sender inn til
IconCard og StippledCard.
BREAKING CHANGE: endrer styling til å passe de nye ikonene.
innebærer blant annet at fargene settes med color og ikke fill
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1661.westeurope.2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1661.westeurope.2.azurestaticapps.net

@kwltrs kwltrs deleted the update-icons-in-components branch February 8, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants