Fix ownership issue for string_pointer and buffer overrun issue for string_array. (#472) #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_array to prevent buffer overrun.
Fixed missing support for based_attribute. Modified the description of SetStringPointer.
Added space to error description.
|
Are there any other issues? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue(#472) of Python string object pointer being directly set during use of string_pointer and mitigates the problem of buffer overrun when using string_array at instance/pointer_attribute.
This change will cause memory leak when using string_pointer if the string is not properly managed, but this is necessary to maintain memory safety in statements such as
pointer.set_string_pointer("string").