Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Add Keychron K2v2 RGB ANSI #360

Merged
merged 2 commits into from Nov 3, 2023
Merged

[Keyboard] Add Keychron K2v2 RGB ANSI #360

merged 2 commits into from Nov 3, 2023

Conversation

ghost
Copy link

@ghost ghost commented Oct 31, 2023 •
edited by ghost
Loading

Description

Add Keychron K2v2 RGB ANSI variant to sn32_develop branch.

Based on previous work of @dexter93 on the K2, @KeijoMika for their work on the K2v2 ISO variant.
Guidance provided by @KeijoMika

Transferred the settings into the info.json file. Added layout file for VIA. Added RGB sleep feature in config.h file.

Supported

  • RGB
  • VIA
  • Bluetooth

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

dexter93
dexter93 requested changes Oct 31, 2023
View reviewed changes
keyboards/keychron/k2/rgb/v2/ansi/info.json Outdated Show resolved Hide resolved
keyboards/keychron/k2/rgb/v2/ansi/info.json Outdated Show resolved Hide resolved
keyboards/keychron/k2/rgb/v2/config.h Outdated Show resolved Hide resolved
keyboards/keychron/k2/rgb/v2/via_json/k2_ansi.json Outdated Show resolved Hide resolved
ghost
ghost commented Oct 31, 2023
View reviewed changes
Copy link
Author

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All requested changes applied.

@ghost ghost requested a review from dexter93 October 31, 2023 19:34
@dexter93 dexter93 merged commit 186310f into SonixQMK:sn32_develop Nov 3, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
keyboard keymap via
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dexter93 @KeijoMika