Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keychron K*: restructure #184

Merged
merged 6 commits into from
Jan 3, 2022
Merged

Keychron K*: restructure #184

merged 6 commits into from
Jan 3, 2022

Conversation

dexter93
Copy link

@dexter93 dexter93 commented Jan 2, 2022

Major restructure of keychron keyboards layout.

  • USB descriptors updated
  • optical switch support
  • common keymaps for each layout
  • VIA enabled across all keymaps
  • new structure is scalable for new revisions and variants
  • ISO/ANSI is handled now
  • K6 White is now using the C* matrix
  • Debounce set to 5 by default

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@dexter93
Copy link
Author

dexter93 commented Jan 2, 2022

This still needs some cleanup for visuals, but it should be good for testing.

Note: VIA json's are missing for most of the keyboards still, and the ones that are there probably need USB descriptor updates for new VID/PID per device.

@dexter93
Copy link
Author

dexter93 commented Jan 3, 2022

Cleanup done. VIA functionality verified. Closing this ASAP since there are keyboard related PR's pending, so they can rebase accordingly

@dexter93 dexter93 merged commit e9b934f into SonixQMK:sn32 Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Keymap inconsistencies
1 participant