Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keychron C1 RGB] Bulk Update #148

Merged
merged 25 commits into from
Dec 2, 2021
Merged

[Keychron C1 RGB] Bulk Update #148

merged 25 commits into from
Dec 2, 2021

Conversation

vjdato21
Copy link

@vjdato21 vjdato21 commented Nov 11, 2021 •
edited
Loading

Description

  • Run MCU at full speed.
  • Add VIA keymap/support.
  • Remove restart keyboard custom keycode.
  • Disable KEYBOARD_SHARED_EP
  • Disable RGB Matrix on USB suspend. (Uses a workaround for now)
  • Minor update to readme.md
  • Minor organizing of info.json
  • Updates to VID and PID.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@vjdato21
[Keychron C1 RGB] 48 MHz + VIA Support + etc.
ac2b103 
- Run Keychron C1 RGB MCU at 48 MHz.
- Add VIA keymap for VIA support.
- Disabled `KEYBOARD_SHARED_EP` for it is no longer needed.
- Removed custom keycode for restarting keyboard as it is no longer needed.
- Slightly updated readme.md.
@vjdato21
[Keychron C1 RGB] Update readme.md
812feb9
@vjdato21
Copy link
Author

vjdato21 commented Nov 14, 2021 •
edited
Loading

Tell me if I need to put my commits in a different branch. Thanks!

@vjdato21 vjdato21 marked this pull request as ready for review November 14, 2021 01:34
@dexter93 dexter93 added this to the Sonix November 2021 Merge milestone Nov 18, 2021
@vjdato21
[Keychron C1 RGB] Organize info.json formatting
3230500
@vjdato21
[Keychron C1 RGB] Merge some files
2cfa086
@vjdato21
[Keychron C1 RGB] Update VIA keymap
4b9d518
@vjdato21
Merge branches 'sn32' and 'sn32' of https://github.com/vjdato21/qmk_f…
e259a48 
…irmware into pr/148
@vjdato21
[Keychron C1 RGB] Attempt to fix conflict
f60c9a4
@vjdato21
Revert "[Keychron C1 RGB] Merge some files"
80f8e49 
This reverts commit 2cfa086.
@vjdato21
Revert "[Keychron C1 RGB] Update VIA keymap"
2618227 
This reverts commit 4b9d518.
@vjdato21
[Keychron C1 RGB] Minor fix keymap
537d5b5
@vjdato21
Update keymap.c
f984e7d
@vjdato21
[Keychron C1 RGB] Change VID and PID
7e399a9
@vjdato21
Revert "Update readme.md"
5452d9d 
This reverts commit f7d350b.
@vjdato21
[Keychron C1 RGB] Remove note
6c72dcc 
- The keyboard now uses a different VID and PID. Thus this issue will no longer be evident.
@vjdato21
Revert "[Keychron C1 RGB] Fix keyboard path"
3908ba2 
This reverts commit 305c80a.
@github-actions github-actions bot removed the python label Nov 22, 2021
@dexter93 dexter93 merged commit 2a0effd into SonixQMK:sn32 Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
keyboard keymap via
Projects
None yet
Milestone
Sonix November 2021 Merge
Development

Successfully merging this pull request may close these issues.
2 participants
@vjdato21 @dexter93