Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLE-993,SLE-998: Fix smart notification links and update SLCORE #766

Merged
merged 3 commits into from
Nov 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
SonarLint for Eclipse
=====================
SonarQube for IDE: Eclipse
==========================

SonarLint helps you deliver [Clean Code](https://www.sonarsource.com/solutions/clean-code/?utm_medium=referral&utm_source=github&utm_campaign=clean-code&utm_content=sonarlint-eclipse) in your IDE.
SonarQube for IDE: Eclipse helps you deliver [Clean Code](https://www.sonarsource.com/solutions/clean-code/?utm_medium=referral&utm_source=github&utm_campaign=clean-code&utm_content=sonarlint-eclipse) in your IDE.

Installing and using
--------------------
Expand All @@ -13,7 +13,7 @@ For offline installation and older versions see the update site archive at https
Have Questions or Feedback?
--------------------------

For SonarLint support questions ("How do I?", "I got this error, why?", ...), please first read the [FAQ](https://community.sonarsource.com/t/frequently-asked-questions/7204) and then head to the [SonarSource forum](https://community.sonarsource.com/c/help/sl). There are chances that a question similar to yours has already been answered.
For SonarQube for IDE support questions ("How do I?", "I got this error, why?", ...), please first read the [FAQ](https://community.sonarsource.com/t/frequently-asked-questions/7204) and then head to the [SonarSource forum](https://community.sonarsource.com/c/help/sl). There are chances that a question similar to yours has already been answered.

Be aware that this forum is a community, so the standard pleasantries ("Hi", "Thanks", ...) are expected. And if you don't get an answer to your thread, you should sit on your hands for at least three days before bumping it. Operators are not standing by. :-)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,9 @@ public class SonarLintDocumentation {
public static final String SONARCLOUD_PRODUCT_LINK = BASE_MARKETING_URL + "/products/sonarcloud";
public static final String SONARCLOUD_SIGNUP_LINK = SONARCLOUD_PRODUCT_LINK + "/signup";

public static final String SONARQUBE_SMART_NOTIFICATIONS = "https://docs.sonarsource.com/sonarqube/latest/user-guide/sonarlint-connected-mode/#smart-notifications";
public static final String SONARCLOUD_SMART_NOTIFICATIONS = "https://docs.sonarsource.com/sonarcloud/improving/sonarlint/#smart-notifications";

public static final String COMMUNITY_FORUM = "https://community.sonarsource.com/c/sl/11";
public static final String COMMUNITY_FORUM_ECLIPSE_RELEASES = "https://community.sonarsource.com/tags/c/sl/sonarlint-releases/37/eclipse";

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
import org.eclipse.swt.widgets.Composite;
import org.eclipse.swt.widgets.Link;
import org.eclipse.swt.widgets.Text;
import org.sonarlint.eclipse.core.documentation.SonarLintDocumentation;
import org.sonarlint.eclipse.ui.internal.SonarLintImages;
import org.sonarlint.eclipse.ui.internal.binding.wizard.connection.ServerConnectionModel.ConnectionType;
import org.sonarlint.eclipse.ui.internal.util.BrowserUtils;
Expand Down Expand Up @@ -96,8 +97,9 @@ public void setVisible(boolean visible) {
final var isSc = model.getConnectionType() == ConnectionType.SONARCLOUD;
final var sqOrSc = isSc ? "Cloud" : "Server";
notificationsEnabledCheckbox.setText("Receive notifications from SonarQube" + sqOrSc);
final var docUrl = isSc ? "https://docs.sonarcloud.io/advanced-setup/sonarlint-smart-notifications/"
: "https://docs.sonarqube.org/latest/user-guide/sonarlint-connected-mode/#smart-notifications";
final var docUrl = isSc
? SonarLintDocumentation.SONARCLOUD_SMART_NOTIFICATIONS
: SonarLintDocumentation.SONARQUBE_SMART_NOTIFICATIONS;
notificationsLink.setText("You will receive <a href=\"" + docUrl + "\">notifications</a> from SonarQube "
+ sqOrSc + " in situations like:");
notificationsDetails.setText(
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@
<tycho.version>4.0.8</tycho.version>

<!-- Sloop embedded CLI version for fragment projects -->
<sloop.version>10.10.0.79544</sloop.version>
<sloop.version>10.10.0.79572</sloop.version>

<!-- SonarQube analysis -->
<sonar.java.source>11</sonar.java.source>
Expand Down
2 changes: 1 addition & 1 deletion target-platforms/commons-build.target
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<dependency>
<groupId>org.sonarsource.sonarlint.core</groupId>
<artifactId>sonarlint-java-client-osgi</artifactId>
<version>10.10.0.79544</version>
<version>10.10.0.79572</version>
<type>jar</type>
</dependency>
</dependencies>
Expand Down