Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLCORE-1051 Allow null value for branch during Open in IDE requests #1169

Merged
merged 8 commits into from
Nov 28, 2024
Merged

SLCORE-1051 Allow null value for branch during Open in IDE requests #1169

merged 8 commits into from
Nov 28, 2024

Conversation

nquinquenel
Copy link
Member

@nquinquenel nquinquenel commented Nov 26, 2024 •
edited by jira bot
Loading

@nquinquenel nquinquenel force-pushed the feature/nq/SLCORE-1051-receive-null-branch-open-in-ide branch 2 times, most recently from fb53771 to 37ecbe2 Compare November 26, 2024 15:09
@nquinquenel nquinquenel marked this pull request as ready for review November 26, 2024 15:26
@nquinquenel nquinquenel force-pushed the feature/nq/SLCORE-1051-receive-null-branch-open-in-ide branch from 957e9ac to 98248f3 Compare November 27, 2024 09:50
sophio-japharidze-sonarsource
sophio-japharidze-sonarsource reviewed Nov 27, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understood correctly, the same changes would be needed for opening fix suggestions.

...re/src/main/java/org/sonarsource/sonarlint/core/embedded/server/ShowIssueRequestHandler.java Outdated Show resolved Hide resolved
.../src/main/java/org/sonarsource/sonarlint/core/rpc/protocol/client/issue/IssueDetailsDto.java Outdated Show resolved Hide resolved
API_CHANGES.md Outdated Show resolved Hide resolved
@nquinquenel nquinquenel force-pushed the feature/nq/SLCORE-1051-receive-null-branch-open-in-ide branch from bf46ef0 to 4ad5b29 Compare November 27, 2024 14:52
@nquinquenel nquinquenel force-pushed the feature/nq/SLCORE-1051-receive-null-branch-open-in-ide branch from 4ad5b29 to 565779d Compare November 27, 2024 15:17
@sonarqube-next SonarQube-Next
Copy link

sonarqube-next bot commented Nov 28, 2024 •
edited
Loading

Quality Gate passed Quality Gate passed

Issues
0 New issues
11 Fixed issues
2 Accepted issues

Measures
0 Security Hotspots
95.7% Coverage on New Code
0.6% Duplication on New Code

See analysis details on SonarQube

thahnen
thahnen approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@thahnen thahnen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

sophio-japharidze-sonarsource
sophio-japharidze-sonarsource approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@nquinquenel nquinquenel merged commit 3c1c3ca into master Nov 28, 2024
14 checks passed
@nquinquenel nquinquenel deleted the feature/nq/SLCORE-1051-receive-null-branch-open-in-ide branch November 28, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophio-japharidze-sonarsource sophio-japharidze-sonarsource sophio-japharidze-sonarsource approved these changes

@thahnen thahnen thahnen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nquinquenel @thahnen @sophio-japharidze-sonarsource