SLCORE-1026 SonarLint is aligned with the custom/new severity for issues #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nquinquenel
force-pushed
the
feature/nq/SLCORE-1026-custom-severities-issues
branch
4 times, most recently
from
3304a7c
to
a7d7b17
Compare
nquinquenel
requested review from
damien-urruty-sonarsource and
eray-felek-sonarsource
nquinquenel
force-pushed
the
feature/nq/SLCORE-1026-custom-severities-issues
branch
from
a7d7b17
to
06f5847
Compare
backend/core/src/main/java/org/sonarsource/sonarlint/core/issue/IssueService.java
Outdated
Show resolved
Hide resolved
backend/core/src/main/java/org/sonarsource/sonarlint/core/issue/IssueService.java
Outdated
Show resolved
Hide resolved
...main/java/org/sonarsource/sonarlint/core/serverapi/push/parsing/IssueChangedEventParser.java
Show resolved
Hide resolved
| @@ -192,8 +192,10 @@ private static ServerIssue adapt(Entity storedIssue) { | |||
| var creationDate = (Instant) requireNonNull(storedIssue.getProperty(CREATION_DATE_PROPERTY_NAME)); | |||
| var userSeverity = (IssueSeverity) storedIssue.getProperty(USER_SEVERITY_PROPERTY_NAME); | |||
| var type = (RuleType) requireNonNull(storedIssue.getProperty(TYPE_PROPERTY_NAME)); | |||
| var impacts = readImpacts(storedIssue.getBlob(IMPACTS_BLOB_NAME)); | |||
There was a problem hiding this comment.
Be aware that for issues we have an incremental update with the pull mechanism. It means no impacts will be returned for all issues that are already stored. For such changes, we might want at some point to force a re-download of all issues. We had a similar case with SLCORE-441
backend/core/src/main/java/org/sonarsource/sonarlint/core/issue/IssueService.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/sonarsource/sonarlint/core/tracking/TaintVulnerabilityTrackingService.java
Outdated
Show resolved
Hide resolved
nquinquenel
force-pushed
the
feature/nq/SLCORE-1026-custom-severities-issues
branch
2 times, most recently
from
de2ca5a
to
ed2759d
Compare
nquinquenel
force-pushed
the
feature/nq/SLCORE-1026-custom-severities-issues
branch
from
ed2759d
to
cbb7fe5
Compare
nquinquenel
requested review from
damien-urruty-sonarsource and
sophio-japharidze-sonarsource
sophio-japharidze-sonarsource
approved these changes
Nov 26, 2024
backend/commons/src/main/java/org/sonarsource/sonarlint/core/commons/SoftwareQuality.java
Show resolved
Hide resolved
...main/java/org/sonarsource/sonarlint/core/serverapi/push/parsing/IssueChangedEventParser.java
Outdated
Show resolved
Hide resolved
nquinquenel
force-pushed
the
feature/nq/SLCORE-1026-custom-severities-issues
branch
from
6461a9d
to
c01f756
Compare
|
nquinquenel
deleted the
feature/nq/SLCORE-1026-custom-severities-issues
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLCORE-1026