SLCORE-400 URL encode quality profile parameter for rules API

SonarSource · Sep 19, 2022 · d152262 · d152262
1 parent b0b6415
commit d152262
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/server-api/src/main/java/org/sonarsource/sonarlint/core/serverapi/rules/RulesApi.java b/server-api/src/main/java/org/sonarsource/sonarlint/core/serverapi/rules/RulesApi.java
@@ -109,7 +109,7 @@ public Collection<ServerActiveRule> getAllActiveRules(String qualityProfileKey,
   private String getSearchByQualityProfileUrl(String qualityProfileKey) {
     var builder = new StringBuilder();
     builder.append("/api/rules/search.protobuf?qprofile=");
-    builder.append(qualityProfileKey);
+    builder.append(UrlUtils.urlEncode(qualityProfileKey));
     serverApiHelper.getOrganizationKey().ifPresent(org -> builder.append("&organization=").append(UrlUtils.urlEncode(org)));
     builder.append("&activation=true&f=templateKey,actives&types=CODE_SMELL,BUG,VULNERABILITY&s=key");
     return builder.toString();

diff --git a/server-api/src/test/java/org/sonarsource/sonarlint/core/serverapi/rules/RulesApiTests.java b/server-api/src/test/java/org/sonarsource/sonarlint/core/serverapi/rules/RulesApiTests.java
@@ -101,7 +101,7 @@ void should_get_rule_from_organization() throws ExecutionException, InterruptedE
   @Test
   void should_get_active_rules_of_a_given_quality_profile() {
     mockServer.addProtobufResponse(
-      "/api/rules/search.protobuf?qprofile=QPKEY&organization=orgKey&activation=true&f=templateKey,actives&types=CODE_SMELL,BUG,VULNERABILITY&s=key&ps=500&p=1",
+      "/api/rules/search.protobuf?qprofile=QPKEY%2B&organization=orgKey&activation=true&f=templateKey,actives&types=CODE_SMELL,BUG,VULNERABILITY&s=key&ps=500&p=1",
       Rules.SearchResponse.newBuilder()
         .setTotal(2)
         .setPs(1)
@@ -125,7 +125,7 @@ void should_get_active_rules_of_a_given_quality_profile() {
 
     var rulesApi = new RulesApi(mockServer.serverApiHelper("orgKey"));
 
-    var activeRules = rulesApi.getAllActiveRules("QPKEY", progress);
+    var activeRules = rulesApi.getAllActiveRules("QPKEY+", progress);
 
     assertThat(activeRules)
       .extracting("ruleKey", "severity", "templateKey", "params")