SONAR-23852 Creates new version structure #734
+46
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davividal
commented
Jan 7, 2025
davividal
force-pushed
the
dkv/sonar-23852-repackaging
branch
from
19ab4f2 to
d3d8317
Compare
jCOTINEAU
reviewed
Jan 9, 2025
| STAGING_IMAGE_NAME: ${GCLOUD_STAGING_REGISTRY}/${GCLOUD_STAGING_PRODUCT_NAME} | ||
| - version: 10/datacenter/search | ||
| - version: 2025.1/datacenter/search |
There was a problem hiding this comment.
should we put 2025.1 or 2025 only ? do you have a special opinion here ?
There was a problem hiding this comment.
That's a good point! I almost made it too generic but opted to use 2025.1 in a last-minute decision.
I thought that it would be easier to duplicate the code for 2025.x, than go from generic to multiple specific versions.
davividal
force-pushed
the
dkv/sonar-23852-repackaging
branch
from
5e57b75 to
4da89c7
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SONAR-23852