-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various fixes including for regressions on latest RC #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also fixes non-wide CV GUI equipment chooser scrolling regression from e8dd5de, remove superfluous seperators Note: frmVeeWide.form with frmVeeWide.java (wide CV GUI) is already out-of-sync and can't handle the custom methods like EquipmentLocation
This also fixes jump jet model being "None" on a loaded mech after adding jump jets
…ty (ala MML), more jump jet info
…fic rules Specifically it used to only work properly in experimental rules. Following was fixed to now work in era-specific rules: - cost/BV now calculated for coolant pods and armored components - armored components are now saved to file
Specifics: - Fix narrow/low profile quirk cost from 2 to 3 - see https://bg.battletech.com/wp-content/uploads/2023/07/Campaign-Operations-2023-07-26-v4.0.pdf - Also fill out its description - Separate out quad version of directional torso mount quirk - Change variable quirk cost from 0 to 1 so user can manually come up with cost by selecting it multiple times
Also remove some redundant omnimeck reset code
Thank you for submitting this. I will be reviewing it this afternoon after work. |
WEKarnesky
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several fixes and misc changes. There's two more PRs that will follow this, one that has fixes for mech and CV turrets and related UI, and the other for some MML compat options.
Improved error handling:
UI fixes:
Other fixes:
Misc: